-
Notifications
You must be signed in to change notification settings - Fork 716
Add Plain Progress Output Mode #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jglogan
merged 5 commits into
apple:main
from
nrthakur:nik/feat/plain-progress-output-mode
Apr 2, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
04263d0
feat: add plain progress output mode
nrthakur 1af848d
fix: allow first plain mode render to fire immediately
nrthakur b9723df
address PR review comments
nrthakur 3c4a688
fix: update copyright year in Flags+ProgressConfig.swift
nrthakur 95bade2
fix: add terminal output tests for plain and document in cmd ref
nrthakur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // Copyright © 2026 Apple Inc. and the container project authors. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import ContainerAPIClient | ||
| import TerminalProgress | ||
|
|
||
| extension Flags.Progress { | ||
| /// Creates a `ProgressConfig` based on the selected progress type. | ||
| /// | ||
| /// For `.none`, progress updates are disabled. For `.ansi`, the given parameters | ||
| /// are used as-is. For `.plain`, ANSI-incompatible features (spinner, clear on finish) | ||
| /// are disabled and the output mode is set to `.plain`. | ||
| func makeConfig( | ||
| description: String = "", | ||
| itemsName: String = "it", | ||
| showTasks: Bool = false, | ||
| showItems: Bool = false, | ||
| showSpeed: Bool = true, | ||
| ignoreSmallSize: Bool = false, | ||
| totalTasks: Int? = nil | ||
| ) throws -> ProgressConfig { | ||
| switch progress { | ||
| case .none: | ||
| return try ProgressConfig(disableProgressUpdates: true) | ||
| case .ansi, .plain: | ||
| let isPlain = progress == .plain | ||
| return try ProgressConfig( | ||
| description: description, | ||
| itemsName: itemsName, | ||
| showSpinner: !isPlain, | ||
| showTasks: showTasks, | ||
| showItems: showItems, | ||
| showSpeed: showSpeed, | ||
| ignoreSmallSize: ignoreSmallSize, | ||
| totalTasks: totalTasks, | ||
| clearOnFinish: !isPlain, | ||
| outputMode: isPlain ? .plain : .ansi | ||
| ) | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.