Skip to content

fix(spark): potential hang with skipped segments on overlapping decompression #2745

Merged
zuston merged 5 commits intoapache:masterfrom
zuston:decompression-fix
Mar 27, 2026
Merged

fix(spark): potential hang with skipped segments on overlapping decompression #2745
zuston merged 5 commits intoapache:masterfrom
zuston:decompression-fix

Conversation

@zuston
Copy link
Copy Markdown
Member

@zuston zuston commented Mar 26, 2026

What changes were proposed in this pull request?

fix the PR #2735

Why are the changes needed?

Does this PR introduce any user-facing change?

No.

How was this patch tested?

@zuston
Copy link
Copy Markdown
Member Author

zuston commented Mar 26, 2026

cc @wForget

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.95%. Comparing base (4637321) to head (aa40749).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...pache/uniffle/client/impl/DecompressionWorker.java 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2745      +/-   ##
============================================
+ Coverage     50.76%   50.95%   +0.18%     
- Complexity     3318     3340      +22     
============================================
  Files           533      533              
  Lines         25808    25918     +110     
  Branches       2354     2363       +9     
============================================
+ Hits          13102    13206     +104     
- Misses        11855    11856       +1     
- Partials        851      856       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

Test Results

 3 185 files  + 33   3 185 suites  +33   6h 53m 18s ⏱️ + 3m 17s
 1 248 tests +  2   1 246 ✅ +  2   1 💤 ±0  1 ❌ ±0 
15 819 runs  +208  15 803 ✅ +209  15 💤 ±0  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit 390ea25. ± Comparison against base commit b80940d.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zuston ,LGTM

roryqi
roryqi previously approved these changes Mar 26, 2026
@zuston zuston merged commit ae417e6 into apache:master Mar 27, 2026
39 of 41 checks passed
@zuston zuston deleted the decompression-fix branch March 27, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants