[SPARK-55600][PYTHON][TEST][FOLLOW-UP] Fix test to verify row count preservation with 0-column schema#54962
Closed
Yicong-Huang wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-55600][PYTHON][TEST][FOLLOW-UP] Fix test to verify row count preservation with 0-column schema#54962Yicong-Huang wants to merge 1 commit intoapache:masterfrom
Yicong-Huang wants to merge 1 commit intoapache:masterfrom
Conversation
…reservation with 0-column schema The existing test used a 0-row DataFrame to test 0-column conversion, which trivially passed without actually verifying the bug fix from SPARK-55600. This change replaces it with a non-empty DataFrame (3 rows) to properly assert that row count is preserved when converting with an empty schema. Also removes the stale TODO(SPARK-55350) comment since the fix has already been merged.
HyukjinKwon
approved these changes
Mar 23, 2026
Contributor
|
merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace it with a non-empty DataFrame so the assertion actually validates row count preservation. Also remove the stale
TODO(SPARK-55350)comment.Why are the changes needed?
The test was not verifying the intended behavior.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing test.
Was this patch authored or co-authored using generative AI tooling?
No.