[SPARK-56075][PYTHON][FOLLOW-UP] Remove remaining dead python error classes#54948
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-56075][PYTHON][FOLLOW-UP] Remove remaining dead python error classes#54948zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
dongjoon-hyun
approved these changes
Mar 23, 2026
Member
There was a problem hiding this comment.
+1, LGTM.
@zhengruifeng , please try to ask Claude Code to write a PR description based on .github/PULL_REQUEST_TEMPLATE , too. Then, it will help you follow the Apache Spark (and ASF) guideline. For example, like the following part. It's much better than writing from the scratches.
-yes, checked with Claude
+Generated-by: Claude Code (Claude Opus 4.6)
spark/.github/PULL_REQUEST_TEMPLATE
Lines 55 to 56 in a5a7588
allisonwang-db
approved these changes
Mar 23, 2026
HyukjinKwon
approved these changes
Mar 23, 2026
Contributor
Author
|
thanks all, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
follow up of #54903, remove remaining dead python error classes
checked with LLM that all unused ones should be removed after this PR
Why are the changes needed?
code clean up
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.6)