Skip to content

(#8494) - Refreshes seq before indexeddb bulkDocs #8495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
filionf wants to merge 13 commits into
base: master
Choose a base branch
from
+75 −2
Open

(#8494) - Refreshes seq before indexeddb bulkDocs #8495

Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
860e550
(#8494) - Refreshes seq before indexeddb bulkDocs
filionf Apr 25, 2022
7e7c371
Merge branch 'master' into refresh-seq-before-update
filionf Mar 21, 2023
8e59fcb
Empty commit
filionf Mar 23, 2023
f1094f0
Merge branch 'master' into refresh-seq-before-update
filionf Aug 28, 2023
9f3d97a
Merge branch 'master' into refresh-seq-before-update
filionf Jul 5, 2024
71dd463
Use META_LOCAL_STORE instead of DOC_STORE to refresh sequence
filionf Jul 5, 2024
576bcc8
retrigger checks
filionf Jul 5, 2024
ce03972
retrigger checks
filionf Jul 5, 2024
0738a33
retrigger checks
filionf Jul 5, 2024
e72d9ac
retrigger checks
filionf Jul 5, 2024
26bff84
Merge remote-tracking branch 'origin/master' into refresh-seq-before-…
filionf Jun 3, 2025
e669c42
Improve error handling in refreshMetadataSeq function
filionf Jun 3, 2025
400a7de
test: add verification for metadata seq refresh before bulkDocs opera…
filionf Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/node_modules/pouchdb-adapter-indexeddb/src/bulkDocs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,17 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
};
}

function refreshMetadataSeq() {
return new Promise(function (resolve) {
Copy link
Copy Markdown
Contributor

@alxndrsn alxndrsn May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance of an error in this Promise, requiring a reject() call?

Copy link
Copy Markdown
Contributor Author

@filionf filionf Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feedback. Thanks, I've made it more robust.

txn.objectStore(DOC_STORE).index('seq').openCursor(null, 'prev').onsuccess = function (evt) {
Copy link
Copy Markdown
Contributor

@alxndrsn alxndrsn Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this have the same effect as:

metaStore.get(META_STORE).onsuccess = function (e) {
  metadata.seq = e.target.result.seq;
  ...
}

?

Copy link
Copy Markdown
Contributor Author

@filionf filionf Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to spend some time analyzing it. It's been too long for me to remember the technical details.

Copy link
Copy Markdown
Contributor Author

@filionf filionf Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does. It seems to be a better solution so I've merged and updated the code to match this technique.

if (evt.target.result) {
metadata.seq = evt.target.result.key;
}
resolve();
};
});
}

function updateSeq(i) {
if (i === lastWriteIndex) {
txn.objectStore(META_STORE).put(metadata);
Expand Down Expand Up @@ -405,8 +416,10 @@ export default function (api, req, opts, metadata, dbOpts, idbChanges, callback)
callback(null, results);
};

// We would like to use promises here, but idb sucks
fetchExistingDocs(txn, docs);
return refreshMetadataSeq().then(function () {
// We would like to use promises here, but idb sucks
fetchExistingDocs(txn, docs);
});
});
}).catch(function (err) {
callback(err);
Expand Down