[core] Fix incorrect sequenceNumber in manifest after row-tracking compaction#7409
Open
juntaozhang wants to merge 3 commits intoapache:masterfrom
Open
[core] Fix incorrect sequenceNumber in manifest after row-tracking compaction#7409juntaozhang wants to merge 3 commits intoapache:masterfrom
juntaozhang wants to merge 3 commits intoapache:masterfrom
Conversation
JingsongLi
reviewed
Mar 12, 2026
|
|
||
| public AppendCompactTask(BinaryRow partition, List<DataFileMeta> files) { | ||
| Preconditions.checkArgument(files != null); | ||
| files.sort(Comparator.comparingLong(DataFileMeta::minSequenceNumber)); |
Contributor
There was a problem hiding this comment.
Should do this sort in Data Evolution class.
Contributor
Author
There was a problem hiding this comment.
Hi @JingsongLi , sorry for the late reply.
This fix is mainly targeted at the row-tracking scenario. Given that sequenceNumber may not be continuous and can even be null, I’ve revised the original implementation to manage this logic within RowDataFileWriter.
Thanks for your time and help. Could you please take another look for this PR?
juntaozhang
force-pushed
the
fix-row-tracking-seq-num
branch
from
6a5fa6d to
2a9efdf
Compare
juntaozhang
force-pushed
the
fix-row-tracking-seq-num
branch
from
650f0dc to
21c5c71
Compare
juntaozhang
force-pushed
the
fix-row-tracking-seq-num
branch
from
21c5c71 to
0e957d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #7408
Tests
API and Format
Documentation
Generative AI tooling