Skip to content

[hotfix] [table] Replace string concatenation with placeholders #7399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yangjf2019 wants to merge 1 commit into from
Closed

[hotfix] [table] Replace string concatenation with placeholders #7399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions paimon-core/src/main/java/org/apache/paimon/table/ExpireChangelogImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ public int expireUntil(long earliestId, long endExclusiveId) {
Set<String> manifestSkippSet = changelogDeletion.manifestSkippingSet(skippingSnapshots);
for (long id = earliestId; id < endExclusiveId; id++) {
if (LOG.isDebugEnabled()) {
LOG.debug("Ready to delete changelog files from changelog #" + id);
LOG.debug("Ready to delete changelog files from changelog #{}", id);
}
Changelog changelog = changelogManager.longLivedChangelog(id);
Predicate<ExpireFileEntry> skipper;
Expand Down Expand Up @@ -218,13 +218,13 @@ public void expireAll() {
Set<String> manifestSkippSet = changelogDeletion.manifestSkippingSet(skippingSnapshots);
for (long id = earliestChangelogId; id <= latestChangelogId; id++) {

LOG.info("Ready to delete changelog files from changelog #" + id);
LOG.info("Ready to delete changelog files from changelog #{}", id);

Changelog changelog;
try {
changelog = changelogManager.tryGetChangelog(id);
} catch (FileNotFoundException e) {
LOG.info("fail to get changelog #" + id);
LOG.info("fail to get changelog #{}", id);
continue;
}
Predicate<ExpireFileEntry> skipper;
Expand Down
6 changes: 3 additions & 3 deletions paimon-core/src/main/java/org/apache/paimon/table/ExpireSnapshotsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ public int expireUntil(long earliestId, long endExclusiveId) {
// id should be (beginInclusiveId, endExclusiveId]
for (long id = beginInclusiveId + 1; id <= endExclusiveId; id++) {
if (LOG.isDebugEnabled()) {
LOG.debug("Ready to delete merge tree files not used by snapshot #" + id);
LOG.debug("Ready to delete merge tree files not used by snapshot #{}", id);
}
Snapshot snapshot;
try {
Expand Down Expand Up @@ -199,7 +199,7 @@ public int expireUntil(long earliestId, long endExclusiveId) {
if (!expireConfig.isChangelogDecoupled()) {
for (long id = beginInclusiveId; id < endExclusiveId; id++) {
if (LOG.isDebugEnabled()) {
LOG.debug("Ready to delete changelog files from snapshot #" + id);
LOG.debug("Ready to delete changelog files from snapshot #{}", id);
}
Snapshot snapshot;
try {
Expand Down Expand Up @@ -239,7 +239,7 @@ public int expireUntil(long earliestId, long endExclusiveId) {
if (skippingSet != null) {
for (long id = beginInclusiveId; id < endExclusiveId; id++) {
if (LOG.isDebugEnabled()) {
LOG.debug("Ready to delete manifests in snapshot #" + id);
LOG.debug("Ready to delete manifests in snapshot #{}", id);
}

Snapshot snapshot;
Expand Down