Skip to content

HerdDB profile for integration tests #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eolivelli wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

HerdDB profile for integration tests #79

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f227291
Start HerdDB profile
Apr 10, 2021
fb95313
fix
Apr 10, 2021
d1b9072
Use embedded mode
Apr 11, 2021
7d291f8
Exclude some tests with HerdDBDictionary
Apr 17, 2021
10dda41
Merge branch 'master' into herddb-docker
eolivelli Apr 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,6 +1102,58 @@
</properties>
</profile>

<!-- Profile for testing with HerdDB -->
<profile>
<id>test-herddb-docker</id>
<activation>
<property>
<name>test-herddb-docker</name>
</property>
</activation>
<dependencies>
<dependency>
<groupId>org.herddb</groupId>
<artifactId>herddb-jdbc</artifactId>
<version>0.22.0</version>
<scope>test</scope>
</dependency>
</dependencies>
<properties>
<connection.driver.name>herddb.jdbc.Driver</connection.driver.name>
Copy link
Copy Markdown
Contributor

@rmannibucau rmannibucau Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about a plain java test since herddb is java? docker is mainly an additional test to enable to test which looks not needed here, wdyt?

Copy link
Copy Markdown
Member

@struberg struberg Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me docker is also fine. The benefit of a docker image is that you drop it and have a very well defined initial status.

Copy link
Copy Markdown
Contributor Author

@eolivelli eolivelli Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the main problem is about adding more jars in the classpath.

I am fine with using in-memory db as well, tests will be probably faster?

we should have both.

I would start with docker in order to not need to spend time in debugging potential problems about re-initialization of the server

Copy link
Copy Markdown
Contributor

@rmannibucau rmannibucau Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would dependency:unpack the zip/stack and just launch it with a dedicated classloader (no conflict wth openjpa)
Docker is fine but don't expect it to be ran often except on the CI from time to time - this is my main point, only Mark runs docker profiles AFAIK.


<connection.url>jdbc:herddb:server:localhost:7000</connection.url>
<connection.username>sa</connection.username>
<connection.password>hdb</connection.password>
<jdbc.DBDictionary />

<!-- DBCP overrides for testing -->
<dbcp.maxIdle>5</dbcp.maxIdle>
<dbcp.minIdle>0</dbcp.minIdle>

</properties>

<build>
<plugins>
<plugin>
<groupId>io.fabric8</groupId>
<artifactId>docker-maven-plugin</artifactId>
<configuration>
<images>
<image>
<name>herddb/herddb:latest</name>
<run>
<ports>
<port>7000:7000</port>
</ports>
</run>
</image>
</images>
</configuration>
</plugin>
</plugins>
</build>
</profile>

<!-- Profile for testing with a custom DB using a system jar -->
<!--
For example, to test with Oracle, you might run:
Expand Down