feat(metrics): Add regression test for metrics recording#7362
Open
dentiny wants to merge 3 commits intoapache:mainfrom
Open
feat(metrics): Add regression test for metrics recording#7362dentiny wants to merge 3 commits intoapache:mainfrom
dentiny wants to merge 3 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I'm been fixing a few metrics-related bugs in the past weeks, and think it'd be good if we could have regression test.
What changes are included in this PR?
In the added unit tests, I focus on failure cases, for example, (1) several cases on server failure; (2) client/server drops requests due to timeout, etc.
Are there any user-facing changes?
No
AI Usage Statement
I wrote down a list of scenarios to test, opus generates the test code for me.