Skip to content

fix(services/onedrive): fix url of onedrive_create_upload_session #7257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emliunix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(services/onedrive): fix url of onedrive_create_upload_session #7257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/services/onedrive/src/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,11 +382,10 @@ impl OneDriveCore {
path: &str,
args: &OpWrite,
) -> Result<Response<Buffer>> {
let parent_path = get_parent(path);
let file_name = get_basename(path);
let url = format!(
"{}:/createUploadSession",
self.onedrive_item_url(parent_path, true),
self.onedrive_item_url(path, true),
);
Comment on lines 385 to 389
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a regression unit test for onedrive_create_upload_session URL construction to ensure the generated endpoint includes the full file path (including filename) and stays consistent with the item.name sent in the request body. This would prevent reintroducing the previous 400 "Name from path does not match name from body" behavior when refactoring URL helpers.

Copilot uses AI. Check for mistakes.
let mut request = Request::post(url).header(header::CONTENT_TYPE, "application/json");

Expand Down
Loading