Fixed: Avoid displaying quantities equal to zero as 1 in the invoice items grid of the View Invoice screen (OFBIZ-13362)#964
Open
golja wants to merge 1 commit intoapache:trunkfrom
Open
Conversation
…rid of the View Invoice screen
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the second issue described in OFBIZ-13362
Even when the invoice item quantity is correctly set to zero in the database, the screen viewInvoice erroneously ‘visualize’ an invoice item reporting one unit of the product.
The problem is due to the fact that the grid 'ListInvoiceItems' used in the viewInvoice screen set the invoice item quantity to one when it is zero. The change in the PR makes sure that the quantity visualized is set to 1 only when the quantity is null.