Skip to content

Fixed: Ensure that the invoice item quantity is set to 1 only if the quantity is null when invoice items are created by the createInvoiceItem service (OFBIZ-13362) #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
golja wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Fixed: Ensure that the invoice item quantity is set to 1 only if the quantity is null when invoice items are created by the createInvoiceItem service (OFBIZ-13362) #963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...counting/src/main/groovy/org/apache/ofbiz/accounting/invoice/InvoiceServicesScript.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ Map createInvoiceItem() {
// if there is no amount and a productItem is supplied fill the amount(price) and description from the product record
// TODO: there are return adjustments now that make this code very broken. The check for price was added as a quick fix.
if (invoiceItem.productId) {
invoiceItem.quantity = invoiceItem.quantity ?: 1
invoiceItem.quantity = (invoiceItem.quantity != null) ? invoiceItem.quantity : 1
if (!invoiceItem.amount) {
GenericValue product = from('Product').where(parameters).cache().queryOne()
invoiceItem.description = product.description
Expand Down
Loading