[MNG-5913] Allow defining aliases for existing server configurations in settings.xml by slawekjaranowski · Pull Request #2333 · apache/maven

slawekjaranowski · 2025-05-13T19:31:17Z

Add the next tag ids to the server in settings.xml

Additional server will be created in memory by SettingsBuilder, so the generated configuration should be transparent to other as Settings#getServers() will return complete list.

https://issues.apache.org/jira/browse/MNG-5913

api/maven-api-settings/src/main/mdo/settings.mdo

cstamas · 2025-05-13T19:54:13Z

This needs to be made sure will not break Maven 3, as same settings is shared by both currently.

slawekjaranowski · 2025-05-13T20:20:01Z

This needs to be made sure will not break Maven 3, as same settings is shared by both currently.

unit test, looks ok for me.

I tested with: mvn help:effective-settings

slawekjaranowski · 2025-05-14T21:10:29Z

ok, who is willing to work on it with me?
If proposition will be generally accepted I will do similar in 3.9.x

I hope such feature will be valuable.

cstamas · 2025-05-14T21:13:11Z

Well, settings with current 3.9.9 are NOT read:

[WARNING] 
[WARNING] Some problems were encountered while building the effective settings
[WARNING] Unrecognised tag: 'aliases' (position: START_TAG seen ...</id>\n     <aliases>... @61:15)  @ /home/cstamas/.m2/settings.xml, line 61, column 15
[WARNING]

Or this is "ok"? Is settings loaded partially or discaded?

cstamas · 2025-05-14T21:14:38Z

I am willing to jump in as Njord does something similar, but my concern is that Maven 3.x is not "forgiving" while readint settings.xml AFAIK. And if we modify XML then things like ./mvnw will work ONLY (for user) if 3.9.10 used?

slawekjaranowski · 2025-05-14T21:17:54Z

Well, settings with current 3.9.9 are NOT read:

[WARNING] 
[WARNING] Some problems were encountered while building the effective settings
[WARNING] Unrecognised tag: 'aliases' (position: START_TAG seen ...</id>\n     <aliases>... @61:15)  @ /home/cstamas/.m2/settings.xml, line 61, column 15
[WARNING]

Or this is "ok"? Is settings loaded partially or discaded?

it is correct because 3.9.x does not have it yet

...ettings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java

slawekjaranowski · 2025-05-14T21:21:01Z

I am willing to jump in as Njord does something similar, but my concern is that Maven 3.x is not "forgiving" while readint settings.xml AFAIK. And if we modify XML then things like ./mvnw will work ONLY (for user) if 3.9.10 used?

I hope we can have next version of settings schema for 3.9.x ... so if someone update own settings alos will use newer version of Maven

Pankraz76

already very nice.
please give last dedication, to reach infinitive higher-order function.

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java

...lder/src/test/java/org/apache/maven/settings/building/DefaultSettingsBuilderFactoryTest.java

Pankraz76

polish

...ettings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java

...ettings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java

slawekjaranowski · 2025-05-15T18:33:08Z

@gnodet @Pankraz76 last suggestions applied

Pankraz76

init by default

...ettings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java

...ettings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java

Pankraz76 · 2025-05-15T19:50:32Z

why we need to change deprecated stuff?

PMD or rewrite, might even do both.
Spot seems ending up being short:

Parameter 'request' is never used #2338

slawekjaranowski · 2025-05-15T20:43:02Z

why we need to change deprecated stuff?

Found this one related:

Parameter 'request' is never used #2338

deprecated staff can be used by Maven 3 plugins - we need support backward compatibility for Maven 3.x

slawekjaranowski · 2025-05-17T07:58:08Z

@gnodet @cstamas any more comments for it?

I will cleanups from comments and will be ready.

cstamas · 2025-05-17T10:05:08Z

I am still unconvinced that this change is backward compatible. Or the idea is that whoever uses this feature must use Maven 4 or latest (upcoming) Maven 3.9.10? What happens if by mistake (or project mvnw) is 3.9.9 or 3.8.8?

slawekjaranowski · 2025-05-17T11:11:16Z

I am still unconvinced that this change is backward compatible. Or the idea is that whoever uses this feature must use Maven 4 or latest (upcoming) Maven 3.9.10? What happens if by mistake (or project mvnw) is 3.9.9 or 3.8.8?

Confirm - for new future Maven 4.x (rc-4+) and 3.9.10+ will be needed.

Such futures will be needed for deployments or for special environments where users use more private repositories.
So if user want to use it simply needs the latest version of Maven.

For older Maven warning will be printed.

cstamas · 2025-05-17T12:23:55Z

For older Maven warning will be printed.

I am aware of warning, but am unaware what exactly happens when that warning is printed: is whole settings ignored, is only the server (with unknown element) ignored... Given we talk about same file that all Maven 3+ would use, I think we need to be careful here. Maven is already printing a LOT to screen, is very easy to miss one line warning and then tinker why build/deploy/whatever failed...

slawekjaranowski · 2025-05-17T14:58:30Z

As I see from my testing only unparsable settings.xml break a Maven build at all
settings.xml with correct xml syntax, but with unkown tags are processed, all recognized settings are correctly read

I can add IT for such case - what happens with unrecognized tag in settings.xml - in separate PR if can help you

slawekjaranowski · 2025-05-20T06:44:33Z

Kindly reminder - Any more comments here? Anything what I can do more ...?

If there are no more requests, I would like to merge it

michael-o

I consider it as confusing having <id/> and <ids/> as subelements. I think this needs to be in Maven 4 first, RC and then in 3.9.x. I think that one server element should have a unique ID and then <aliases/>.

There is also a JIRA issue which requests to completely decouple credentials from server elements. Which makes creds reusable throughout.

michael-o · 2025-05-20T09:24:40Z

Looking at this I am still convinced that is should not be delivered with 3.9.10.

michael-o · 2025-05-20T09:40:32Z

FTR: https://issues.apache.org/jira/browse/MNG-5615

michael-o · 2025-05-20T09:42:32Z

Yet another problem is that we are abusing one server structure for multiple ones, e.g., you are settings headers or other transport-related config. It will be applied to mulitple servers, but you need to split them up actually except credentials.

jira-importer · 2025-07-06T09:10:08Z

Resolve #7757

…in settings.xml Add the next tag ids to the server in settings.xml Additional server will be created in memory by SettingsBuilder, so the generated configuration should be transparent to other as Settings#getServers() will return complete list.

slawekjaranowski · 2026-04-12T08:36:00Z

@michael-o @cstamas I refreshed a PR 😄 with last suggestions

to build pass I need fixes in modello - in progress

michael-o · 2026-04-12T19:16:10Z

Will check next week...

michael-o · 2026-04-14T07:42:43Z

api/maven-api-settings/src/main/mdo/settings.mdo

+          <version>1.3.0+</version>
+          <description>
+            List of additional server aliases. For each alias, an additional server will be generated by copying the entire configuration, but using a different ID.
+            This is useful when the same credentials should be used for multiple servers.          </description>


Trailing whitespace

michael-o · 2026-04-14T07:45:35Z

...ettings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java

+                .id(id)
+                .aliases(List.of())
+                .build());
+    }


This looks very ugly. It is the clien't responsibility to traverse the Settings object, no?

It is the core of change.

Based on additional tag - aliases we create a next server instance in memory on server list.
So all others plugins tools will see destination list of servers original declared in settings and created based on aliases tag.

I do remember that Modello allows to add Java code to Settings. Why can't we inject/improve the code in the model directly?

so you propose to override a getServers method directly in modelo?

Yes, correct.

ok, I will check if it will be easier?

@michael-o
It will be impossible (in easy way) to implement in code settings.mdo, we use velocity templates to generate code for 4.x and for 3.x.

Share the spot where this is done. Modello made it possible :-(

Share the spot where this is done. Modello made it possible :-(

There is two templates for generating output from modello files:
https://github.com/apache/maven/blob/master/src/mdo/model.vm
https://github.com/apache/maven/blob/master/src/mdo/model-v3.vm

I see some of code in settings.mdo so will look again

I don't see a way to provide such code in settings.mdo

slawekjaranowski requested review from cstamas, gnodet and michael-o May 13, 2025 19:31

slawekjaranowski added the enhancement New feature or request label May 13, 2025

slawekjaranowski self-assigned this May 13, 2025

slawekjaranowski commented May 13, 2025

View reviewed changes

api/maven-api-settings/src/main/mdo/settings.mdo Outdated Show resolved Hide resolved

slawekjaranowski commented May 13, 2025

View reviewed changes

api/maven-api-settings/src/main/mdo/settings.mdo Show resolved Hide resolved

slawekjaranowski force-pushed the MNG-5913 branch from 7230d9e to 563d2e2 Compare May 13, 2025 20:18

Pankraz76 reviewed May 14, 2025

View reviewed changes

...ettings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java Outdated Show resolved Hide resolved

Pankraz76 approved these changes May 14, 2025

View reviewed changes

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java Outdated Show resolved Hide resolved

Pankraz76 reviewed May 14, 2025

View reviewed changes

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java Show resolved Hide resolved

Pankraz76 reviewed May 14, 2025

View reviewed changes

...lder/src/test/java/org/apache/maven/settings/building/DefaultSettingsBuilderFactoryTest.java Outdated Show resolved Hide resolved

Pankraz76 mentioned this pull request May 14, 2025

[POC] rewrite-maven-plugin: Introduce OpenRewrite by Moderne #2322

Closed

slawekjaranowski force-pushed the MNG-5913 branch 2 times, most recently from a959fb0 to e0b3b6b Compare May 14, 2025 22:18

Pankraz76 reviewed May 15, 2025

View reviewed changes

Pankraz76 mentioned this pull request May 15, 2025

Modernize codebase with Java improvements #2277

Open

gnodet reviewed May 15, 2025

View reviewed changes

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSettingsBuilder.java Outdated Show resolved Hide resolved

gnodet reviewed May 15, 2025

View reviewed changes

...ettings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java Outdated Show resolved Hide resolved

Pankraz76 mentioned this pull request May 15, 2025

ReplaceCollectToListWithToList openrewrite/rewrite-static-analysis#558

Closed

slawekjaranowski requested review from Pankraz76 and gnodet May 15, 2025 18:33

This was referenced May 15, 2025

Parameter 'request' is never used #2338

Closed

make fields of DefaultSettingsBuilder final #2339

Closed

Pankraz76 reviewed May 15, 2025

View reviewed changes

...ettings-builder/src/main/java/org/apache/maven/settings/building/DefaultSettingsBuilder.java Outdated Show resolved Hide resolved

slawekjaranowski force-pushed the MNG-5913 branch from 5167598 to c726fc1 Compare May 19, 2025 19:05

michael-o requested changes May 20, 2025

View reviewed changes

slawekjaranowski added 5 commits April 11, 2026 14:21

Apply review suggestion - 1

b248d2d

Apply review suggestion - 2

e96fbd1

cleanup of introduced comments

81933fe

Refresh changes - rename ids to aliases

d634949

slawekjaranowski force-pushed the MNG-5913 branch from c726fc1 to d634949 Compare April 11, 2026 18:18

slawekjaranowski requested a review from michael-o April 12, 2026 08:36

Use modello 2.7.0

feb0392

michael-o requested changes Apr 14, 2026

View reviewed changes

Fix trailing whitespace

6abdb32

Conversation

slawekjaranowski commented May 13, 2025

Uh oh!

Uh oh!

Uh oh!

cstamas commented May 13, 2025

Uh oh!

slawekjaranowski commented May 13, 2025

Uh oh!

slawekjaranowski commented May 14, 2025

Uh oh!

cstamas commented May 14, 2025

Uh oh!

cstamas commented May 14, 2025

Uh oh!

slawekjaranowski commented May 14, 2025

Uh oh!

Uh oh!

slawekjaranowski commented May 14, 2025

Uh oh!

Pankraz76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pankraz76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

slawekjaranowski commented May 15, 2025

Uh oh!

Pankraz76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pankraz76 commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slawekjaranowski commented May 15, 2025

Uh oh!

slawekjaranowski commented May 17, 2025

Uh oh!

cstamas commented May 17, 2025

Uh oh!

slawekjaranowski commented May 17, 2025

Uh oh!

cstamas commented May 17, 2025

Uh oh!

slawekjaranowski commented May 17, 2025

Uh oh!

slawekjaranowski commented May 20, 2025

Uh oh!

michael-o left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-o commented May 20, 2025

Uh oh!

michael-o commented May 20, 2025

Uh oh!

michael-o commented May 20, 2025

Uh oh!

jira-importer commented Jul 6, 2025

Uh oh!

slawekjaranowski commented Apr 12, 2026

Uh oh!

michael-o commented Apr 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Pankraz76 commented May 15, 2025 •

edited

Loading

michael-o left a comment •

edited

Loading

slawekjaranowski Apr 14, 2026 •

edited

Loading