Fix #11899: DefaultSettingsXmlFactory.write() always emits location comments#11929
Closed
Fix #11899: DefaultSettingsXmlFactory.write() always emits location comments#11929
Conversation
…omments DefaultSettingsXmlFactory and DefaultToolchainsXmlFactory always emitted InputLocation comments because they created bare StaxWriter instances whose addLocationInformation field defaults to true. This aligns both factories with DefaultModelXmlFactory by defaulting location tracking to false and only enabling it when an explicit inputLocationFormatter is provided via XmlWriterRequest. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Claude Code on behalf of Guillaume Nodet Closing in favor of #11924 which was raised first with the same fix for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultSettingsXmlFactory.write()to defaultaddLocationInformationtofalseand only enable it when an explicitinputLocationFormatteris provided viaXmlWriterRequest, matching the existing behavior ofDefaultModelXmlFactory.write()DefaultToolchainsXmlFactory.write()which had the identical bugCloses #11899
Test plan
DefaultSettingsXmlFactoryTestverifies no location comments without formatterDefaultSettingsXmlFactoryTestverifies location comments appear with explicit formattermaven-implpassClaude Code on behalf of Guillaume Nodet