Open
Conversation
|
@utafrali @gnodet @cstamas Thank you for the fix and reviewing! |
waterlx
reviewed
Apr 13, 2026
| if (inputModel.getParent() != null && inputModel.getParent().getRelativePath() == null) { | ||
| String relPath; | ||
| if (parentModel.getPomFile() != null && isBuildRequest()) { | ||
| if (parentModel.getPomFile() != null && inputModel.getPomFile() != null && isBuildRequest()) { |
There was a problem hiding this comment.
Just try to understand if it is as expected / a correct behavior to fall back inputModel's relPath to ".." when its getPomFile() is null.
Non-binding +1.
There was a problem hiding this comment.
This comment has been resolved, but my "Resolve comment" is rejected by 401 (I have no idea why...). Please kindly move forward. Thank you!
Author
|
Yep, that's expected - when getPomFile() is null, we fall back to '..' to keep a valid path for the model hierarchy. |
Author
|
no problem, moving forward with the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11919
Got an NPE in DefaultModelBuilder when reading the effective model with Maven 4 RC5. The code was already checking if parentModel has a pom file, but then it was calling getPomFile() on inputModel without checking if it was null. Added the null check before using it.
mvn verifyto make sure basic checks pass.