Open
Conversation
Adds StructLikeSet<bool kValidate = true>, a hash set for StructLike rows backed by an internal arena allocator. Key design points: - Deep-copies inserted rows into a monotonic_buffer_resource arena; string data and nested struct/list/map scalars are fully materialized so the set owns its memory independently of the caller - Transparent heterogeneous lookup: Contains() does not allocate a temporary key - Hash and equality semantics match the Java reference implementation (String.hashCode, StructLikeHash, ListHash; float/double use canonical NaN bits and distinguish ±0.0) - Schema validation (field count + scalar type) on Insert/Contains; can be disabled via kValidate=false (UncheckedStructLikeSet) when the caller guarantees conformance - Internal Arena wrapper containers use std::pmr::vector
wgtmac
force-pushed
the
struct_like_set
branch
3 times, most recently
from
78b5c16 to
589b7f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds StructLikeSet, a hash set for StructLike rows backed by an internal arena allocator.
Key design points: