fix(test): Use in-memory H2 database instead of file-based in TestGravitinoMetricsUpdater#10563
Merged
roryqi merged 1 commit intoapache:mainfrom Mar 27, 2026
Merged
Conversation
…vitinoMetricsUpdater The testInitializeDefaultUsesGenericJdbcRepository test was creating file-based H2 databases that were never cleaned up, leaving leftover .db files on disk after each test run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Code Coverage Report
|
roryqi
approved these changes
Mar 27, 2026
Contributor
|
@puchengy LGTM. Merged to the branch main. |
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Mar 27, 2026
…based in TestGravitinoMetricsUpdater (apache#10563) ## What changes were proposed in this pull request? Changed testInitializeDefaultUsesGenericJdbcRepository to use an in-memory H2 database (jdbc:h2:mem:) instead of a file-based H2 database (jdbc:h2:file:). ## Why are the changes needed? The test was creating file-based H2 databases at data/test-metrics-updater-default-<nanoTime>.db that were never cleaned up, leaving leftover .db files on disk after each test run. The other similar test (testInitializeWithJdbcConfigStillUsesGenericJdbcRepository) already uses in-memory H2 correctly. Fix: # ## Does this PR introduce any user-facing change? No. ## How was this patch tested? Ran ./gradlew :maintenance:optimizer:test --tests "org.apache.gravitino.maintenance.optimizer.updater.metrics.TestGravitinoMetricsUpdater" -PskipITs — all 8 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changed testInitializeDefaultUsesGenericJdbcRepository to use an in-memory H2 database (jdbc:h2:mem:) instead of a file-based H2 database
(jdbc:h2:file:).
Why are the changes needed?
The test was creating file-based H2 databases at data/test-metrics-updater-default-.db that were never cleaned up, leaving leftover .db files
on disk after each test run. The other similar test (testInitializeWithJdbcConfigStillUsesGenericJdbcRepository) already uses in-memory H2 correctly.
Fix: #
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran ./gradlew :maintenance:optimizer:test --tests "org.apache.gravitino.maintenance.optimizer.updater.metrics.TestGravitinoMetricsUpdater" -PskipITs —
all 8 tests pass.