[#10529] improvement(all): upgrade Jetty to 9.4.58 and exclude unused Jetty from hive-metastore3-libs#10532
Merged
diqiu50 merged 4 commits intoapache:mainfrom Mar 27, 2026
Conversation
5f159f7 to
4426a1b
Compare
Code Coverage Report
|
Contributor
|
Can you also take a look? I have no more comments. |
diqiu50
reviewed
Mar 25, 2026
4426a1b to
db1e5ef
Compare
diqiu50
reviewed
Mar 26, 2026
diqiu50
reviewed
Mar 27, 2026
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Mar 27, 2026
…unused Jetty from hive-metastore3-libs (apache#10532) ### What changes were proposed in this pull request? 1. Updated jetty version from 9.4.51.v20230217 to 9.4.58.v20250814 in `libs.versions.toml`. 2. Added exclude("org.eclipse.jetty") to both hadoop2-common and hive3-metastore dependencies in `build.gradle.kts`. ### Why are the changes needed? 1. The Jetty version upgrade brings the latest patches for modules that directly use Jetty (iceberg-rest-server, lance-rest-server). 2. In hive-metastore3-libs, Jetty 9.3.20 is a transitive dependency from hadoop-common:3.1.0 (pulled in via hive3-metastore). Due to HiveClientClassLoader's classloader isolation, Hadoop classes are loaded from the base classloader which already has no Jetty, making these Jetty jars dead code. Both hadoop2-common and hive3-metastore need the exclude because Gradle resolves hadoop-common 2.10.2 → 3.1.0 (higher version wins), creating two dependency paths to Jetty. Fix: apache#10529 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? 1. Verified compileJava, jar, and test pass for :catalogs:catalog-hive and :catalogs:hive-metastore3-libs 2. Confirmed Jetty no longer appears in hive-metastore3-libs runtimeClasspath dependency tree --------- Co-authored-by: Yuhui <hui@datastrato.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
libs.versions.toml.build.gradle.kts.Why are the changes needed?
Fix: #10529
Does this PR introduce any user-facing change?
No.
How was this patch tested?