Skip to content

[#10280] Support Iceberg snapshot maintenance procedures via Gravitino Trino#10500

Open
laserninja wants to merge 1 commit intoapache:mainfrom
laserninja:iceberg-snapshot-maintainance-trino
Open

[#10280] Support Iceberg snapshot maintenance procedures via Gravitino Trino#10500
laserninja wants to merge 1 commit intoapache:mainfrom
laserninja:iceberg-snapshot-maintainance-trino

Conversation

@laserninja
Copy link
Copy Markdown
Contributor

@laserninja laserninja commented Mar 22, 2026

What changes were proposed in this pull request?

Delegate Iceberg snapshot maintenance procedures (expire_snapshots, remove_orphan_files, rewrite_data_files/optimize, rewrite_manifests) from the Gravitino Trino Connector to the internal Iceberg connector.

Changes:

  • GravitinoConnector: Add getProcedures() and getTableProcedures()
  • GravitinoMetadata: Add getLayoutForTableExecute(), beginTableExecute(), finishTableExecute() in base class
  • Version-specific metadata classes: Add getTableHandleForExecute() and executeTableExecute() with correct SPI signatures per Trino version
  • GravitinoPageSinkProvider: Add createPageSink for ConnectorTableExecuteHandle
  • Add unit tests (TestGravitinoConnectorProcedures) and integration tests

Why are the changes needed?

Fix #10280

Does this PR introduce any user-facing change?

No.

How was this patch tested?

All the tests passed

…avitino Trino Connector

Delegate Iceberg snapshot maintenance procedures (expire_snapshots,
remove_orphan_files, rewrite_data_files/optimize, rewrite_manifests)
from the Gravitino Trino Connector to the internal Iceberg connector.

Changes:
- GravitinoConnector: Add getProcedures() and getTableProcedures()
- GravitinoMetadata: Add getLayoutForTableExecute(), beginTableExecute(),
  finishTableExecute() in base class
- Version-specific metadata classes: Add getTableHandleForExecute() and
  executeTableExecute() with correct SPI signatures per Trino version
- GravitinoPageSinkProvider: Add createPageSink for ConnectorTableExecuteHandle
- Add unit tests (TestGravitinoConnectorProcedures) and integration tests

Closes apache#10280
@laserninja laserninja marked this pull request as ready for review March 24, 2026 18:09
@laserninja laserninja changed the title [#10280] Support Iceberg snapshot maintenance procedures via Gravitin… [#10280] Support Iceberg snapshot maintenance procedures via Gravitino Trino Mar 24, 2026
@roryqi roryqi requested a review from diqiu50 March 26, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support Iceberg snapshot maintenance procedures (expire_snapshots, remove_orphan_files, rewrite_data_files) via Gravitino Trino Connector

1 participant