FINERACT-2494: Add unit tests for ApiParameterHelper in fineract-core#5665
FINERACT-2494: Add unit tests for ApiParameterHelper in fineract-core#5665Ambika-Sony wants to merge 1 commit intoapache:developfrom
Conversation
There was a problem hiding this comment.
Ticket is Wrong and i cant understand the usecase of this.
As ticket titles
FINERACT-2494: [Testing] Add unit tests for ApiParameterHelper in fineract-core.
There was a problem hiding this comment.
Remove ApiResponses Annotation. It is not required
There was a problem hiding this comment.
same here
Hi @Aman-Mittal,
My apologies for the earlier confusion. A recent rebase onto the 1.15.0 modular structure accidentally included unrelated files from other modules.
I have now rectified the PR to align strictly with the FINERACT-2494 ticket scope. It now contains only:
ApiParameterHelper.java: Optimized regex logic.
ApiParameterHelperTest.java: Added a comprehensive JUnit 5 test suite covering command IDs, fields, locale, and pagination.
All unrelated changes have been removed, and the build is successful. Ready for re-review!
There was a problem hiding this comment.
This If else can be simplified more
Ambika-Sony
force-pushed
the
FINERACT-2494-v2-clean
branch
from
b9cb038 to
d28d87f
Compare
Ambika-Sony
changed the title
2 participants
This Pull Request standardizes the operationId naming conventions within the Savings module API resources (SavingsAccountsApiResource.java).
By providing explicit and unique operationId values in the @operation Swagger annotations, we ensure that client-side SDKs (like the Fineract Java and TypeScript clients) generate clean, predictable, and user-friendly method names.
Key Technical Achievements
Architectural Migration: Successfully transitioned the standardization logic from the legacy fineract-provider structure into the new 1.15.0-SNAPSHOT modular architecture.
Upstream Synchronization: Performed a manual rebase against upstream/develop to resolve complex conflicts in GitHub workflows and the newly created fineract-savings sub-module.
Structural Integrity: Resolved JPA configuration path conflicts (persistence.xml) across multiple modules (fineract-loan, fineract-cob, fineract-investor) caused by the recent project refactor.
Clean History: Utilized a git reset --soft workflow to ensure a single, clean, and high-quality commit on top of the latest project state.
Verification Results
Local Build: Verified with ./gradlew :fineract-savings:compileJava — BUILD SUCCESSFUL.
Static Analysis: Verified that the new module paths are correctly mapped and that no new checkstyle violations were introduced in the Savings API resource.
Parity: Confirmed that all operationId values align with the patterns used in other standardized modules.
Checklist
[x] Write the commit message as per our guidelines.
[x] Acknowledge that we will not review PRs that are not passing the build ("green").
[x] Follow our coding conventions.
[x] This PR is focused on a single task (Savings API standardization).