FINERACT-2549: Migrate InstanceModeIntegrationTest from RestAssured to fineract-client-feign#5658
FINERACT-2549: Migrate InstanceModeIntegrationTest from RestAssured to fineract-client-feign#5658Dpk376 wants to merge 2 commits intoapache:developfrom
Conversation
|
@Dpk376 please make sure to sign your commits ,refer [CONTRIBUTING.md]. Also Fineract-2441 points to BI connector and demonstration ,please create a separate issue to properly track this via JIRA. |
c5c0d9b to
396e5ff
Compare
…o fineract-client-feign
396e5ff to
6e4dabb
Compare
… for OfficeHelper
Hi @DeathGun44 , thanks for the feedback! Commit signatures: All commits are now GPG-signed and verified. You can see the "Verified" badge on each commit. |
|
@Dpk376 This is a GSoC ticket .the ticket clearly mentions "No one should work on this specific ticket unless assigned - the GSOC candidate we choose will be assigned this ticket." so your pr description closes #FINERACT-2454 doesn;t make sense, please create a separate jira ticket if you want to work on this for a PoC or otherwise. |
Hi @DeathGun44, thank you for the clarification — I understand now that FINERACT-2454 is the GSoC tracking ticket and should not be closed by contributor PRs. I'll create a separate Jira ticket for this test migration work and update both PRs accordingly. Appreciate the heads up! |
I've created a separate JIRA ticket [FINERACT-2549] to properly track this test migration work and updated both PRs to reference it instead. |
What this PR does
Migrates
InstanceModeIntegrationTestfrom the deprecated RestAssured-basedhelpers to the typed
fineract-client-feignclient, as part of FINERACT-2549.Changes
SchedulerJobHelper: Added no-arg constructor; replacedgetSchedulerJobIdByShortNameand
runSchedulerJobwith feign-based implementations usingFineractClientHelperInstanceModeIntegrationTest: Removed all RestAssured boilerplate (requestSpec,responseSpec,Utils.initializeRESTAssured()); migratedClientHelper.createClientand
schedulerJobHelper.runSchedulerJobcalls to feign; error cases now useassertThrows(CallFailedRuntimeException.class, ...)Checklist
./gradlew spotlessApplypassed./gradlew :integration-tests:compileTestJavapassedPart of FINERACT-2549
Related to FINERACT-2454
gsoc-fineract-evidence