minor: Add QOS filtering for coordinator endpoints#19271
Open
cryptoe wants to merge 2 commits intoapache:masterfrom
Open
minor: Add QOS filtering for coordinator endpoints#19271cryptoe wants to merge 2 commits intoapache:masterfrom
cryptoe wants to merge 2 commits intoapache:masterfrom
Conversation
cryptoe
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public static int getNumThreadsFromProperties(Properties properties) | ||
| { | ||
| final String value = properties.getProperty("druid.server.http.numThreads"); | ||
| return value == null ? getDefaultNumThreads() : Integer.parseInt(value); |
| // Set druid.coordinator.server.maxConcurrentRequests=-1 to disable. | ||
| final int serverHttpNumThreads = ServerConfig.getNumThreadsFromProperties(properties); | ||
| final int maxConcurrentRequests = properties.containsKey("druid.coordinator.server.maxConcurrentRequests") | ||
| ? Integer.parseInt(properties.getProperty("druid.coordinator.server.maxConcurrentRequests")) |
| // Set druid.indexer.server.maxConcurrentActions=-1 to disable. | ||
| final int serverHttpNumThreads = ServerConfig.getNumThreadsFromProperties(properties); | ||
| final int maxConcurrentActions = properties.containsKey("druid.indexer.server.maxConcurrentActions") | ||
| ? Integer.parseInt(properties.getProperty("druid.indexer.server.maxConcurrentActions")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add QoS filtering to the Coordinator to protect health check endpoints under load
The Coordinator had no request throttling, meaning a burst of slow API requests (segment load status, datasource queries, compaction configs, etc.) could exhaust the Jetty thread pool and make /status/health and /status/ready unresponsive. This is the same problem the Overlord solved in #18033 for its action endpoints.