Skip to content

[feat](group commit) add group_commit_mode in table property #61242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 3 commits into from
Mar 16, 2026
+436 −35
Merged

[feat](group commit) add group_commit_mode in table property #61242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0132cc9
[feat](group commit) add group_commit_mode in table property
mymeiyi Mar 12, 2026
2b59cf8
fix
mymeiyi Mar 12, 2026
28dfdf8
fix case
mymeiyi Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions be/src/load/stream_load/stream_load_context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ std::string StreamLoadContext::to_json() const {
} else {
writer.Key("GroupCommit");
writer.Bool(true);
writer.Key("GroupCommitMode");
writer.String(group_commit_mode.c_str());
writer.Key("LoadId");
writer.String(id.to_string().c_str());
}

// status
Expand Down
1 change: 1 addition & 0 deletions be/src/load/stream_load/stream_load_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ class StreamLoadContext {
TFileFormatType::type format = TFileFormatType::FORMAT_CSV_PLAIN;
TFileCompressType::type compress_type = TFileCompressType::UNKNOWN;
bool group_commit = false;
std::string group_commit_mode = "";

std::shared_ptr<MessageBodySink> body_sink;
std::shared_ptr<io::StreamLoadPipe> pipe;
Expand Down
12 changes: 12 additions & 0 deletions be/src/load/stream_load/stream_load_executor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ Status StreamLoadExecutor::begin_txn(StreamLoadContext* ctx) {
}
request.__set_request_id(ctx->id.to_thrift());
request.__set_backend_id(_exec_env->cluster_info()->backend_id);
if (ctx->group_commit_mode.empty()) {
request.__set_use_table_group_commit_mode(true);
}

TLoadTxnBeginResult result;
Status status;
Expand Down Expand Up @@ -217,6 +220,15 @@ Status StreamLoadExecutor::begin_txn(StreamLoadContext* ctx) {
}
return status;
}
if (ctx->group_commit_mode.empty() && result.__isset.table_group_commit_mode) {
auto table_group_commit_mode = result.table_group_commit_mode;
if (iequal(table_group_commit_mode, "async_mode") ||
iequal(table_group_commit_mode, "sync_mode")) {
ctx->group_commit = true;
ctx->group_commit_mode = table_group_commit_mode;
return Status::OK();
}
}
ctx->txn_id = result.txnId;
if (result.__isset.db_id) {
ctx->db_id = result.db_id;
Expand Down
100 changes: 67 additions & 33 deletions be/src/service/http/action/stream_load.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ bvar::LatencyRecorder g_stream_load_commit_and_publish_latency_ms("stream_load",

static constexpr size_t MIN_CHUNK_SIZE = 64 * 1024;
static const std::string CHUNK = "chunked";
static const std::string OFF_MODE = "off_mode";
static const std::string SYNC_MODE = "sync_mode";
static const std::string ASYNC_MODE = "async_mode";

#ifdef BE_TEST
TStreamLoadPutResult k_stream_load_put_result;
Expand Down Expand Up @@ -254,6 +257,7 @@ int StreamLoadAction::on_header(HttpRequest* req) {

LOG(INFO) << "new income streaming load request." << ctx->brief() << ", db=" << ctx->db
<< ", tbl=" << ctx->table << ", group_commit=" << ctx->group_commit
<< ", group_commit_mode=" << ctx->group_commit_mode
<< ", HTTP headers=" << req->get_all_headers();
ctx->begin_receive_and_read_data_cost_nanos = MonotonicNanos();

Expand Down Expand Up @@ -366,6 +370,9 @@ Status StreamLoadAction::_on_header(HttpRequest* http_req, std::shared_ptr<Strea
int64_t begin_txn_start_time = MonotonicNanos();
RETURN_IF_ERROR(_exec_env->stream_load_executor()->begin_txn(ctx.get()));
ctx->begin_txn_cost_nanos = MonotonicNanos() - begin_txn_start_time;
if (ctx->group_commit) {
RETURN_IF_ERROR(_check_wal_space(ctx->group_commit_mode, ctx->body_bytes));
}
Copy link
Contributor

@github-actions github-actions bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Low] _check_wal_space called with body_bytes=0

At this point in _on_header, ctx->body_bytes is initialized to 0 (set at line 304). The body hasn't been received yet. So _check_wal_space(ctx->group_commit_mode, ctx->body_bytes) is called with content_length=0, which always passes the load_size_smaller_than_wal_limit(0) check.

This means the WAL space check is effectively a no-op for the table-property group commit path. The explicit header path has a proper check in _can_group_commit (line 943) using the Content-Length header value.

Consider using the Content-Length from the HTTP header instead:

if (ctx->group_commit) {
    int64_t content_length = http_req->header(HttpHeaders::CONTENT_LENGTH).empty()
                             ? 0 : std::stoll(http_req->header(HttpHeaders::CONTENT_LENGTH));
    RETURN_IF_ERROR(_check_wal_space(ctx->group_commit_mode, content_length));
}

}

// process put file
Expand Down Expand Up @@ -767,12 +774,7 @@ Status StreamLoadAction::_process_put(HttpRequest* http_req,
request.__set_stream_per_node(stream_per_node);
}
if (ctx->group_commit) {
if (!http_req->header(HTTP_GROUP_COMMIT).empty()) {
request.__set_group_commit_mode(http_req->header(HTTP_GROUP_COMMIT));
} else {
// used for wait_internal_group_commit_finish
request.__set_group_commit_mode("sync_mode");
}
request.__set_group_commit_mode(ctx->group_commit_mode);
}

if (!http_req->header(HTTP_COMPUTE_GROUP).empty()) {
Expand Down Expand Up @@ -811,7 +813,7 @@ Status StreamLoadAction::_process_put(HttpRequest* http_req,
if (config::is_cloud_mode() && ctx->two_phase_commit && ctx->is_mow_table()) {
return Status::NotSupported("stream load 2pc is unsupported for mow table");
}
if (http_req->header(HTTP_GROUP_COMMIT) == "async_mode") {
if (iequal(ctx->group_commit_mode, ASYNC_MODE)) {
// FIXME find a way to avoid chunked stream load write large WALs
size_t content_length = 0;
if (!http_req->header(HttpHeaders::CONTENT_LENGTH).empty()) {
Expand Down Expand Up @@ -886,17 +888,24 @@ void StreamLoadAction::_save_stream_load_record(std::shared_ptr<StreamLoadContex
}
}

Status StreamLoadAction::_handle_group_commit(HttpRequest* req,
std::shared_ptr<StreamLoadContext> ctx) {
std::string group_commit_mode = req->header(HTTP_GROUP_COMMIT);
if (!group_commit_mode.empty() && !iequal(group_commit_mode, "sync_mode") &&
!iequal(group_commit_mode, "async_mode") && !iequal(group_commit_mode, "off_mode")) {
return Status::InvalidArgument(
"group_commit can only be [async_mode, sync_mode, off_mode]");
}
if (config::wait_internal_group_commit_finish) {
group_commit_mode = "sync_mode";
Status StreamLoadAction::_check_wal_space(const std::string& group_commit_mode,
int64_t content_length) {
if (iequal(group_commit_mode, ASYNC_MODE) &&
!load_size_smaller_than_wal_limit(content_length)) {
std::stringstream ss;
ss << "There is no space for group commit stream load async WAL. This stream load "
"size is "
<< content_length
<< ". WAL dir info: " << ExecEnv::GetInstance()->wal_mgr()->get_wal_dirs_info_string();
LOG(WARNING) << ss.str();
return Status::Error<EXCEEDED_LIMIT>(ss.str());
}
return Status::OK();
}

Status StreamLoadAction::_can_group_commit(HttpRequest* req, std::shared_ptr<StreamLoadContext> ctx,
std::string& group_commit_header,
bool& can_group_commit) {
int64_t content_length = req->header(HttpHeaders::CONTENT_LENGTH).empty()
? 0
: std::stoll(req->header(HttpHeaders::CONTENT_LENGTH));
Expand All @@ -907,13 +916,11 @@ Status StreamLoadAction::_handle_group_commit(HttpRequest* req,
LOG(WARNING) << ss.str();
return Status::InvalidArgument(ss.str());
}
// allow chunked stream load in flink
auto is_chunk = !req->header(HttpHeaders::TRANSFER_ENCODING).empty() &&
req->header(HttpHeaders::TRANSFER_ENCODING).find(CHUNK) != std::string::npos;
if (group_commit_mode.empty() || iequal(group_commit_mode, "off_mode") ||
(content_length == 0 && !is_chunk)) {
if (content_length == 0 && !is_chunk) {
// off_mode and empty
ctx->group_commit = false;
can_group_commit = false;
return Status::OK();
}
if (is_chunk) {
Expand All @@ -930,20 +937,47 @@ Status StreamLoadAction::_handle_group_commit(HttpRequest* req,
iequal(req->header(HTTP_UNIQUE_KEY_UPDATE_MODE), "UPDATE_FLEXIBLE_COLUMNS"));
if (!partial_columns && !partitions && !temp_partitions && !ctx->two_phase_commit &&
!update_mode) {
if (!config::wait_internal_group_commit_finish && !ctx->label.empty()) {
if (!config::wait_internal_group_commit_finish && !group_commit_header.empty() &&
!ctx->label.empty()) {
return Status::InvalidArgument("label and group_commit can't be set at the same time");
}
Copy link
Contributor

@github-actions github-actions bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[High] Label check incorrectly rejects labeled stream loads on tables with group_commit_mode property

When the user does NOT set the group_commit HTTP header (empty group_commit_header), but the table has group_commit_mode=async_mode/sync_mode, this code path is still reached via _handle_group_commit → _can_group_commit. If the user provides a label (which is normal for stream loads), this returns InvalidArgument("label and group_commit can't be set at the same time").

The problem: the user never explicitly requested group commit — they just have a table property. This is a behavioral regression because existing users who always set labels would suddenly get errors after someone sets the table property.

Suggestion: Either skip this check when group_commit_header is empty (table-property path), or move the label conflict check to after the FE responds confirming the table actually uses group commit. For example:

if (!group_commit_header.empty() && !config::wait_internal_group_commit_finish && !ctx->label.empty()) {
    return Status::InvalidArgument("label and group_commit can't be set at the same time");
}

This ensures only explicit header-based group commit rejects labels, while the table-property path allows labels (and falls through to a normal non-group-commit load when a label is present).

ctx->group_commit = true;
if (iequal(group_commit_mode, "async_mode")) {
if (!load_size_smaller_than_wal_limit(content_length)) {
std::stringstream ss;
ss << "There is no space for group commit stream load async WAL. This stream load "
"size is "
<< content_length << ". WAL dir info: "
<< ExecEnv::GetInstance()->wal_mgr()->get_wal_dirs_info_string();
LOG(WARNING) << ss.str();
return Status::Error<EXCEEDED_LIMIT>(ss.str());
}
RETURN_IF_ERROR(_check_wal_space(group_commit_header, content_length));
can_group_commit = true;
}
return Status::OK();
}

Status StreamLoadAction::_handle_group_commit(HttpRequest* req,
std::shared_ptr<StreamLoadContext> ctx) {
std::string group_commit_header = req->header(HTTP_GROUP_COMMIT);
if (!group_commit_header.empty() && !iequal(group_commit_header, SYNC_MODE) &&
!iequal(group_commit_header, ASYNC_MODE) && !iequal(group_commit_header, OFF_MODE)) {
return Status::InvalidArgument(
"group_commit can only be [async_mode, sync_mode, off_mode]");
}
if (config::wait_internal_group_commit_finish) {
group_commit_header = SYNC_MODE;
}

// if group_commit_header is off_mode, we will not use group commit
if (iequal(group_commit_header, OFF_MODE)) {
ctx->group_commit_mode = OFF_MODE;
ctx->group_commit = false;
return Status::OK();
}
bool can_group_commit = false;
RETURN_IF_ERROR(_can_group_commit(req, ctx, group_commit_header, can_group_commit));
if (!can_group_commit) {
ctx->group_commit_mode = OFF_MODE;
ctx->group_commit = false;
} else {
if (!group_commit_header.empty()) {
ctx->group_commit_mode = group_commit_header;
ctx->group_commit = true;
} else {
// use table property to decide group commit or not
ctx->group_commit_mode = "";
Copy link
Contributor

@github-actions github-actions bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Medium] Parallel code path: HttpStreamAction not updated

The HttpStreamAction (http_stream.cpp) has its own _handle_group_commit method that does NOT support the table-property group commit mode. It treats an empty group_commit header as "no group commit" and returns immediately. Unlike StreamLoadAction, it doesn't call begin_txn (the transaction is opened by FE via NativeInsertStmt), so the mechanism used here (empty group_commit_mode → begin_txn queries FE for table property) doesn't directly apply.

However, the feature description says "For stream load, if it not set group_commit header, use the table property as the group commit mode". This should apply to both stream load endpoints. Consider either:

  1. Adding table-property support to HttpStreamAction in this PR, or
  2. Documenting this as a known limitation and filing a follow-up issue.

ctx->group_commit = false;
}
}
return Status::OK();
Expand Down
3 changes: 3 additions & 0 deletions be/src/service/http/action/stream_load.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ class StreamLoadAction : public HttpHandler {
Status _handle(std::shared_ptr<StreamLoadContext> ctx, HttpRequest* req);
Status _data_saved_path(HttpRequest* req, std::string* file_path, int64_t file_bytes);
Status _process_put(HttpRequest* http_req, std::shared_ptr<StreamLoadContext> ctx);
Status _can_group_commit(HttpRequest* http_req, std::shared_ptr<StreamLoadContext> ctx,
std::string& group_commit_header, bool& can_group_commit);
void _save_stream_load_record(std::shared_ptr<StreamLoadContext> ctx, const std::string& str);
Status _check_wal_space(const std::string& group_commit_mode, int64_t content_length);
Status _handle_group_commit(HttpRequest* http_req, std::shared_ptr<StreamLoadContext> ctx);
void _on_finish(std::shared_ptr<StreamLoadContext> ctx, HttpRequest* req);
void _send_reply(std::shared_ptr<StreamLoadContext> ctx, HttpRequest* req);
Expand Down
2 changes: 2 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2569,6 +2569,7 @@ public void updateTableProperties(Database db, String tableName, Map<String, Str
add(PropertyAnalyzer.PROPERTIES_TIME_SERIES_COMPACTION_GOAL_SIZE_MBYTES);
add(PropertyAnalyzer.PROPERTIES_TIME_SERIES_COMPACTION_FILE_COUNT_THRESHOLD);
add(PropertyAnalyzer.PROPERTIES_TIME_SERIES_COMPACTION_TIME_THRESHOLD_SECONDS);
add(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_MODE);
add(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_INTERVAL_MS);
add(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_DATA_BYTES);
add(PropertyAnalyzer.PROPERTIES_ENABLE_MOW_LIGHT_DELETE);
Expand Down Expand Up @@ -2682,6 +2683,7 @@ public void updateTableProperties(Database db, String tableName, Map<String, Str
&& !properties.containsKey(PropertyAnalyzer.PROPERTIES_ENABLE_SINGLE_REPLICA_COMPACTION)
&& !properties.containsKey(PropertyAnalyzer.PROPERTIES_DISABLE_AUTO_COMPACTION)
&& !properties.containsKey(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_INTERVAL_MS)
&& !properties.containsKey(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_MODE)
&& !properties.containsKey(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_DATA_BYTES)
&& !properties.containsKey(PropertyAnalyzer.PROPERTIES_SKIP_WRITE_INDEX_ON_LOAD)
&& !properties.containsKey(PropertyAnalyzer.PROPERTIES_AUTO_ANALYZE_POLICY)
Expand Down
6 changes: 6 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4032,6 +4032,12 @@ private static void addOlapTablePropertyInfo(OlapTable olapTable, StringBuilder
sb.append(",\n\"").append(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_DATA_BYTES).append("\" = \"");
sb.append(olapTable.getGroupCommitDataBytes()).append("\"");

// group commit mode (only show when not off_mode)
if (!olapTable.getGroupCommitMode().equalsIgnoreCase(PropertyAnalyzer.GROUP_COMMIT_MODE_OFF)) {
sb.append(",\n\"").append(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_MODE).append("\" = \"");
sb.append(olapTable.getGroupCommitMode()).append("\"");
}

// enable delete on delete predicate
if (olapTable.getKeysType() == KeysType.UNIQUE_KEYS && olapTable.getEnableUniqueKeyMergeOnWrite()) {
sb.append(",\n\"").append(PropertyAnalyzer.PROPERTIES_ENABLE_MOW_LIGHT_DELETE)
Expand Down
8 changes: 8 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1698,6 +1698,14 @@ public int getGroupCommitDataBytes() {
return getOrCreatTableProperty().getGroupCommitDataBytes();
}

public void setGroupCommitMode(String groupCommitMode) {
getOrCreatTableProperty().setGroupCommitMode(groupCommitMode);
}

public String getGroupCommitMode() {
return getOrCreatTableProperty().getGroupCommitMode();
}

public Boolean hasSequenceCol() {
return getSequenceCol() != null;
}
Expand Down
9 changes: 9 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/catalog/TableProperty.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,6 +764,15 @@ public int getGroupCommitDataBytes() {
Integer.toString(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_DATA_BYTES_DEFAULT_VALUE)));
}

public void setGroupCommitMode(String groupCommitMode) {
properties.put(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_MODE, groupCommitMode);
}

public String getGroupCommitMode() {
return properties.getOrDefault(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_MODE,
PropertyAnalyzer.GROUP_COMMIT_MODE_OFF);
}

public void setRowStoreColumns(List<String> rowStoreColumns) {
if (rowStoreColumns != null && !rowStoreColumns.isEmpty()) {
modifyTableProperties(PropertyAnalyzer.PROPERTIES_STORE_ROW_COLUMN, "true");
Expand Down
21 changes: 21 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/cloud/alter/CloudSchemaChangeHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ public void updateTableProperties(Database db, String tableName, Map<String, Str
throws UserException {
final Set<String> allowedProps = new HashSet<String>() {
{
add(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_MODE);
add(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_INTERVAL_MS);
add(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_DATA_BYTES);
add(PropertyAnalyzer.PROPERTIES_FILE_CACHE_TTL_SECONDS);
Expand Down Expand Up @@ -152,6 +153,21 @@ public void updateTableProperties(Database db, String tableName, Map<String, Str
}
param.ttlSeconds = ttlSeconds;
param.type = UpdatePartitionMetaParam.TabletMetaType.TTL_SECONDS;
} else if (properties.containsKey(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_MODE)) {
String groupCommitMode = PropertyAnalyzer.analyzeGroupCommitMode(properties, false);
olapTable.readLock();
try {
if (groupCommitMode.equalsIgnoreCase(olapTable.getGroupCommitMode())) {
LOG.info("groupCommitMode:{} is equal with olapTable.groupCommitMode():{}",
groupCommitMode, olapTable.getGroupCommitMode());
return;
}
partitions.addAll(olapTable.getPartitions());
} finally {
olapTable.readUnlock();
}
param.groupCommitMode = groupCommitMode;
param.type = UpdatePartitionMetaParam.TabletMetaType.GROUP_COMMIT_MODE;
} else if (properties.containsKey(PropertyAnalyzer.PROPERTIES_GROUP_COMMIT_INTERVAL_MS)) {
int groupCommitIntervalMs = PropertyAnalyzer.analyzeGroupCommitIntervalMs(properties, false);
olapTable.readLock();
Expand Down Expand Up @@ -384,6 +400,7 @@ public enum TabletMetaType {
INMEMORY,
PERSISTENT,
TTL_SECONDS,
GROUP_COMMIT_MODE,
GROUP_COMMIT_INTERVAL_MS,
GROUP_COMMIT_DATA_BYTES,
COMPACTION_POLICY,
Expand All @@ -401,6 +418,7 @@ public enum TabletMetaType {
boolean isPersistent = false;
boolean isInMemory = false;
long ttlSeconds = 0;
String groupCommitMode;
long groupCommitIntervalMs = 0;
long groupCommitDataBytes = 0;
String compactionPolicy;
Expand Down Expand Up @@ -460,6 +478,9 @@ public void updateCloudPartitionMeta(Database db,
case GROUP_COMMIT_DATA_BYTES:
infoBuilder.setGroupCommitDataBytes(param.groupCommitDataBytes);
break;
case GROUP_COMMIT_MODE:
infoBuilder.setGroupCommitMode(param.groupCommitMode);
break;
case COMPACTION_POLICY:
infoBuilder.setCompactionPolicy(param.compactionPolicy);
break;
Expand Down
24 changes: 24 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,11 @@ public class PropertyAnalyzer {
public static final int PROPERTIES_GROUP_COMMIT_DATA_BYTES_DEFAULT_VALUE
= Config.group_commit_data_bytes_default_value;

public static final String PROPERTIES_GROUP_COMMIT_MODE = "group_commit_mode";
public static final String GROUP_COMMIT_MODE_OFF = "off_mode";
public static final String GROUP_COMMIT_MODE_ASYNC = "async_mode";
public static final String GROUP_COMMIT_MODE_SYNC = "sync_mode";

public static final String PROPERTIES_ENABLE_MOW_LIGHT_DELETE =
"enable_mow_light_delete";
public static final boolean PROPERTIES_ENABLE_MOW_LIGHT_DELETE_DEFAULT_VALUE
Expand Down Expand Up @@ -1908,6 +1913,25 @@ public static int analyzeGroupCommitDataBytes(Map<String, String> properties, bo
return groupCommitDataBytes;
}

public static String analyzeGroupCommitMode(Map<String, String> properties, boolean removeProperty)
throws AnalysisException {
String groupCommitMode = GROUP_COMMIT_MODE_OFF;
if (properties != null && properties.containsKey(PROPERTIES_GROUP_COMMIT_MODE)) {
groupCommitMode = properties.get(PROPERTIES_GROUP_COMMIT_MODE);
if (!groupCommitMode.equalsIgnoreCase(GROUP_COMMIT_MODE_OFF)
&& !groupCommitMode.equalsIgnoreCase(GROUP_COMMIT_MODE_ASYNC)
&& !groupCommitMode.equalsIgnoreCase(GROUP_COMMIT_MODE_SYNC)) {
throw new AnalysisException("Invalid group_commit_mode: " + groupCommitMode
+ ". Valid values: " + GROUP_COMMIT_MODE_OFF + ", " + GROUP_COMMIT_MODE_ASYNC
+ ", " + GROUP_COMMIT_MODE_SYNC);
}
if (removeProperty) {
properties.remove(PROPERTIES_GROUP_COMMIT_MODE);
}
}
return groupCommitMode.toLowerCase();
}

/**
* Check the type property of the catalog props.
*/
Expand Down
7 changes: 7 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2966,6 +2966,13 @@ private boolean createOlapTable(Database db, CreateTableInfo createTableInfo) th
throw new DdlException(e.getMessage());
}

try {
String groupCommitMode = PropertyAnalyzer.analyzeGroupCommitMode(properties, true);
olapTable.setGroupCommitMode(groupCommitMode);
} catch (Exception e) {
throw new DdlException(e.getMessage());
}

try {
TEncryptionAlgorithm tdeAlgorithm = PropertyAnalyzer.analyzeTDEAlgorithm(properties);
olapTable.setEncryptionAlgorithm(tdeAlgorithm);
Expand Down
Loading
Loading