Skip to content

add doc for group_commit_mode table property#3465

Open
mymeiyi wants to merge 1 commit intoapache:masterfrom
mymeiyi:add-group-commit-doc
Open

add doc for group_commit_mode table property#3465
mymeiyi wants to merge 1 commit intoapache:masterfrom
mymeiyi:add-group-commit-doc

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Mar 16, 2026

add doc for pr: apache/doris#61242

Versions

  • dev
  • 4.x
  • 3.x
  • 2.1

Languages

  • Chinese
  • English

Docs Checklist

  • Checked by AI
  • Test Cases Built

Copilot AI review requested due to automatic review settings March 16, 2026 03:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Group Commit manual documentation (English + Chinese, current + v4.x) to explain the new group_commit_mode table property and how it interacts with existing Stream Load / INSERT INTO configuration.

Changes:

  • Add a new “Table Property Configuration / 表属性配置” section describing group_commit_mode, including create/alter/view examples and precedence rules.
  • Clarify precedence in the INSERT INTO VALUES section (session variable vs table property).
  • Clarify Stream Load behavior when the group_commit header is omitted and a table property is set.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
docs/data-operate/import/group-commit-manual.md Adds English current docs for group_commit_mode table property and precedence notes.
versioned_docs/version-4.x/data-operate/import/group-commit-manual.md Adds the same English content for v4.x versioned docs.
i18n/zh-CN/docusaurus-plugin-content-docs/current/data-operate/import/group-commit-manual.md Adds Chinese current docs for group_commit_mode table property and precedence notes.
i18n/zh-CN/docusaurus-plugin-content-docs/version-4.x/data-operate/import/group-commit-manual.md Adds the same Chinese content for v4.x versioned docs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@mymeiyi mymeiyi force-pushed the add-group-commit-doc branch from d6998b9 to 9d54c68 Compare March 16, 2026 03:11
dataroaring pushed a commit to apache/doris that referenced this pull request Mar 16, 2026
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

1. Create table support set `group_commit_mode` table property 
```
CREATE TABLE ... PROPERTIES(
    "group_commit_mode" = "async_mode"
);
```
2. Support alter this property
```
ALTER TABLE ... SET ("group_commit_mode" = "off_mode");
```
3. Show create table shows this property if its value is not `off_mode`
4. For stream load, if it not set `group_commit` header, use the table
property as the group commit mode; if it set `group_commit` header, use
the header value.
5. doc: apache/doris-website#3465


### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants