Allow bare columns in GROUPING SETS expressions#2288
Open
funcpp wants to merge 1 commit intoapache:mainfrom
Open
Allow bare columns in GROUPING SETS expressions#2288funcpp wants to merge 1 commit intoapache:mainfrom
funcpp wants to merge 1 commit intoapache:mainfrom
Conversation
GROUPING SETS used parse_tuple(false, true) which required each element to be parenthesized, while CUBE and ROLLUP already used parse_tuple(true, true) allowing bare columns. This inconsistency meant GROUPING SETS (a, b, c) failed to parse despite being valid syntax in PostgreSQL, Databricks, and other dialects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_tuple(false, true)toparse_tuple(true, true)for GROUPING SETS inparse_group_by_expr, matching CUBE and ROLLUPGROUPING SETS required each element to be parenthesized, while CUBE and ROLLUP already accepted bare columns. This meant valid syntax like
GROUPING SETS (a, b, c)failed to parse. The PostgreSQL grammar explicitly allowsexpressionas a grouping element.The modifier path (added in #1653) already uses
parse_tuple(true, true)for GROUPING SETS — this PR fixes the expression path to be consistent.Test plan