CAUSEWAY-3975: Open Telemetry Integration#3464
Draft
andi-huber wants to merge 27 commits intomainfrom
Draft
Conversation
8bbbea2 to
fad6996
Compare
initial commit Task-Url: https://issues.apache.org/jira/browse/CAUSEWAY-3975
hope to better integrate with micrometer API
- using the old method instead
properly spanning till interaction closes
OpenTelemetryServerRequestObservationConvention
fad6996 to
ed6a660
Compare
TODO don't record observations quicker than 2 ms say With Micrometer Observation API, it seems there is no way to discard already started Observations. Perhaps we can prevent those from being sent over the wire later.
andi-huber
commented
Mar 28, 2026
| */ | ||
| InteractionContext interactionContext | ||
| ) { | ||
| Runnable onCloseCallback) implements AutoCloseable { |
Contributor
Author
There was a problem hiding this comment.
I don't like that as the final answer, because we don't really know how to handle potential exceptions of the runnable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task-Url: https://issues.apache.org/jira/browse/CAUSEWAY-3975
Proposal: make observation an opt-in choice based on profile
observationbeing active, which allows to opt-in only for deployment scenarios where observation is desiredMinimal Setup (for Applications)
Maven
Config
Spring
disable metric export
Docker