Skip to content

GH-49499: [C++] Improve arrow vcpkg port integration #49543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raulcd merged 1 commit into from
Mar 18, 2026
Merged

GH-49499: [C++] Improve arrow vcpkg port integration #49543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ list(PREPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake_modules")
# vcpkg (ab)uses CMAKE_TOOLCHAIN_FILE to inject its logic into CMake
if(ARROW_DEPENDENCY_SOURCE STREQUAL "VCPKG")
include(Usevcpkg)
elseif(ARROW_PACKAGE_KIND STREQUAL "vcpkg")
set(ARROW_VCPKG ON)
endif()

project(arrow VERSION "${ARROW_BASE_VERSION}")
Expand Down
9 changes: 6 additions & 3 deletions cpp/cmake_modules/FindSnappyAlt.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,12 @@ if(Snappy_FOUND)
set(SnappyAlt_FOUND TRUE)
return()
else()
# The Conan's Snappy package always uses Snappy::snappy and it's
# an INTERFACE_LIBRARY.
get_target_property(Snappy Snappy::snappy TYPE)
# The Snappy packages in Conan and vcpkg always use
# Snappy::snappy.
#
# The Snappy package in Conan use an INTERFACE_LIBRARY for
# Snappy::snappy.
get_target_property(Snappy_TYPE Snappy::snappy TYPE)
if(Snappy_TYPE STREQUAL "STATIC_LIBRARY" OR Snappy_TYPE STREQUAL
"INTERFACE_LIBRARY")
set(Snappy_TARGET Snappy::snappy)
Expand Down
Loading