[Variant] Align cast logic for variant_get to cast kernel for numeric/bool types#9563
Open
klion26 wants to merge 3 commits intoapache:mainfrom
Open
[Variant] Align cast logic for variant_get to cast kernel for numeric/bool types#9563klion26 wants to merge 3 commits intoapache:mainfrom
klion26 wants to merge 3 commits intoapache:mainfrom
Conversation
klion26
changed the title
github-actions
bot
added
arrow
klion26
commented
Mar 16, 2026
Member
Author
klion26
left a comment
klion26
left a comment
There was a problem hiding this comment.
@scovich This is what is in my mind to align cast logic for variant_get with cast kernel, current, only changed int/float/double/bool (no decimal for now).
Currently, this will change some behaviors (details in inline comments). Please help review this when you're in free, thanks.
| Variant::Int64(i) if fits_precision::<11>(i) => Some(f16::from_f32(i as _)), | ||
| _ => None, | ||
| } | ||
| self.as_num::<f16>() |
Member
Author
There was a problem hiding this comment.
This will change the behavior from before. Now 65536 will return Some(inf) instead of None.
| Variant::Int64(i) => num_cast::<i64, T>(i), | ||
| Variant::Float(f) => num_cast::<f32, T>(f), | ||
| Variant::Double(d) => num_cast::<f64, T>(d), | ||
| Variant::Decimal4(d) if d.scale() == 0 => num_cast::<_, T>(d.integer()), |
Member
Author
There was a problem hiding this comment.
from/to_decimal needs to be added in a following commit if the direction is right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
variant_getto cast kernel for numeric/bool types #9564 .What changes are included in this PR?
Align tests with cast kernel
Are these changes tested?
Covered by the existing tests
Are there any user-facing changes?
No