arrow-select: fix MutableArrayData interleave for ListView#9560
Open
asubiotto wants to merge 1 commit intoapache:mainfrom
Open
arrow-select: fix MutableArrayData interleave for ListView#9560asubiotto wants to merge 1 commit intoapache:mainfrom
asubiotto wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
asubiotto
force-pushed
the
asubiotto/lvmut
branch
from
d049805 to
093008f
Compare
Contributor
Contributor
|
I think I prefer #9562 |
Contributor
Author
|
Happy to go with whichever, my goal is to just fix this for MutableArrayData so we can compare the specialized interleave implementation fairly |
Contributor
|
Haha that was precisely my comment on #9558 |
The previous code did not extend child data buffers. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
asubiotto
force-pushed
the
asubiotto/lvmut
branch
from
093008f to
80a3d7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code did not extend child data buffers.
I'm preparing a PR for an optimized listview interleave, but wanted to make sure the fallback path was correct before comparing benchmarks.
Which issue does this PR close?
Rationale for this change
Fix a bug
What changes are included in this PR?
Bugfix and test
Are these changes tested?
Yes
Are there any user-facing changes?
ListView interleaves did not succeed previously.