Skip to content

[minor] Download clickbench file when missing#9553

Merged
alamb merged 2 commits intoapache:mainfrom
Dandandan:download_hits_1
Mar 17, 2026
Merged

[minor] Download clickbench file when missing#9553
alamb merged 2 commits intoapache:mainfrom
Dandandan:download_hits_1

Conversation

@Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Mar 13, 2026 •
edited
Loading

Which issue does this PR close?

  • Closes #NNN.

Rationale for this change

I want it to download the file when it's not there

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Mar 13, 2026
@Dandandan
Copy link
Contributor Author

Dandandan commented Mar 13, 2026

run benchmark arrow_reader_clickbench

@adriangbot
Copy link

adriangbot commented Mar 13, 2026

Benchmark job started for this request (job bench-c4056813119-211). Results will be posted here when complete.

@apache apache deleted a comment from adriangbot Mar 13, 2026
@adriangbot
Copy link

adriangbot commented Mar 13, 2026

🤖 Arrow criterion benchmark running (GKE) | trigger
Linux bench-c4056813119-211-d894b 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux
Comparing download_hits_1 (7584269) to 3931179 (merge-base) diff
BENCH_NAME=arrow_reader_clickbench
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench
BENCH_FILTER=
Results will be posted here when complete

@adriangbot
Copy link

adriangbot commented Mar 13, 2026

Benchmark for this request failed.

Last 20 lines of output:

Click to expand 
Cloning into '/workspace/arrow-rs-base/testing'...
    Updating crates.io index
     Locking 417 packages to latest compatible versions
      Adding generic-array v0.14.7 (available: v0.14.9)
      Adding matchit v0.8.4 (available: v0.8.6)
      Adding rand v0.9.2 (available: v0.10.0)
rustc 1.94.0 (4a4ef493e 2026-03-02)
7584269168b63e4f7f1d22ea9e3f185edbd4ddf6
393117979882e97a15125edd142c70a5e2c16386
Looking for ClickBench files starting in current_dir and all parent directories: "/workspace/arrow-rs-base/parquet"
    Finished `bench` profile [optimized] target(s) in 0.14s
     Running benches/arrow_reader_clickbench.rs (target/release/deps/arrow_reader_clickbench-33fb2462f739b0f7)
Could not find hits_1.parquet in directory or parents: "/workspace/arrow-rs-base/parquet". Download it via

wget --continue https://datasets.clickhouse.com/hits_compatible/athena_partitioned/hits_1.parquet

thread 'main' (15931) panicked at parquet/benches/arrow_reader_clickbench.rs:618:9:
Stopping
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p parquet --bench arrow_reader_clickbench`

@adriangbot
Copy link

adriangbot commented Mar 13, 2026

🤖 Arrow criterion benchmark running (GKE) | trigger
Linux bench-c4056813119-211-4mm7l 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux
Comparing download_hits_1 (7584269) to 3931179 (merge-base) diff
BENCH_NAME=arrow_reader_clickbench
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench
BENCH_FILTER=
Results will be posted here when complete

@adriangbot
Copy link

adriangbot commented Mar 13, 2026

Benchmark for this request failed.

Last 20 lines of output:

Click to expand 
Cloning into '/workspace/arrow-rs-base/testing'...
    Updating crates.io index
     Locking 417 packages to latest compatible versions
      Adding generic-array v0.14.7 (available: v0.14.9)
      Adding matchit v0.8.4 (available: v0.8.6)
      Adding rand v0.9.2 (available: v0.10.0)
rustc 1.94.0 (4a4ef493e 2026-03-02)
7584269168b63e4f7f1d22ea9e3f185edbd4ddf6
393117979882e97a15125edd142c70a5e2c16386
Looking for ClickBench files starting in current_dir and all parent directories: "/workspace/arrow-rs-base/parquet"
    Finished `bench` profile [optimized] target(s) in 0.14s
     Running benches/arrow_reader_clickbench.rs (target/release/deps/arrow_reader_clickbench-33fb2462f739b0f7)
Could not find hits_1.parquet in directory or parents: "/workspace/arrow-rs-base/parquet". Download it via

wget --continue https://datasets.clickhouse.com/hits_compatible/athena_partitioned/hits_1.parquet

thread 'main' (15378) panicked at parquet/benches/arrow_reader_clickbench.rs:618:9:
Stopping
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p parquet --bench arrow_reader_clickbench`

@adriangbot
Copy link

adriangbot commented Mar 13, 2026

🤖 Arrow criterion benchmark running (GKE) | trigger
Linux bench-c4056813119-211-kfqxx 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux
Comparing download_hits_1 (7584269) to 3931179 (merge-base) diff
BENCH_NAME=arrow_reader_clickbench
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench
BENCH_FILTER=
Results will be posted here when complete

@adriangbot
Copy link

adriangbot commented Mar 13, 2026

Benchmark for this request failed.

Last 20 lines of output:

Click to expand 
Cloning into '/workspace/arrow-rs-base/testing'...
    Updating crates.io index
     Locking 417 packages to latest compatible versions
      Adding generic-array v0.14.7 (available: v0.14.9)
      Adding matchit v0.8.4 (available: v0.8.6)
      Adding rand v0.9.2 (available: v0.10.0)
rustc 1.94.0 (4a4ef493e 2026-03-02)
7584269168b63e4f7f1d22ea9e3f185edbd4ddf6
393117979882e97a15125edd142c70a5e2c16386
Looking for ClickBench files starting in current_dir and all parent directories: "/workspace/arrow-rs-base/parquet"
    Finished `bench` profile [optimized] target(s) in 0.13s
     Running benches/arrow_reader_clickbench.rs (target/release/deps/arrow_reader_clickbench-33fb2462f739b0f7)
Could not find hits_1.parquet in directory or parents: "/workspace/arrow-rs-base/parquet". Download it via

wget --continue https://datasets.clickhouse.com/hits_compatible/athena_partitioned/hits_1.parquet

thread 'main' (15387) panicked at parquet/benches/arrow_reader_clickbench.rs:618:9:
Stopping
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p parquet --bench arrow_reader_clickbench`

@adriangbot
Copy link

adriangbot commented Mar 13, 2026

🤖 Arrow criterion benchmark running (GKE) | trigger
Linux bench-c4056813119-211-qf5w8 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux
Comparing download_hits_1 (7584269) to 3931179 (merge-base) diff
BENCH_NAME=arrow_reader_clickbench
BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench
BENCH_FILTER=
Results will be posted here when complete

@adriangbot
Copy link

adriangbot commented Mar 13, 2026

Benchmark for this request failed.

Last 20 lines of output:

Click to expand 
Cloning into '/workspace/arrow-rs-base/testing'...
    Updating crates.io index
     Locking 417 packages to latest compatible versions
      Adding generic-array v0.14.7 (available: v0.14.9)
      Adding matchit v0.8.4 (available: v0.8.6)
      Adding rand v0.9.2 (available: v0.10.0)
rustc 1.94.0 (4a4ef493e 2026-03-02)
7584269168b63e4f7f1d22ea9e3f185edbd4ddf6
393117979882e97a15125edd142c70a5e2c16386
Looking for ClickBench files starting in current_dir and all parent directories: "/workspace/arrow-rs-base/parquet"
    Finished `bench` profile [optimized] target(s) in 0.14s
     Running benches/arrow_reader_clickbench.rs (target/release/deps/arrow_reader_clickbench-33fb2462f739b0f7)
Could not find hits_1.parquet in directory or parents: "/workspace/arrow-rs-base/parquet". Download it via

wget --continue https://datasets.clickhouse.com/hits_compatible/athena_partitioned/hits_1.parquet

thread 'main' (15378) panicked at parquet/benches/arrow_reader_clickbench.rs:618:9:
Stopping
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p parquet --bench arrow_reader_clickbench`

@Dandandan Dandandan changed the title Download clickbench file when missing [minor] Download clickbench file when missing Mar 13, 2026
@Dandandan
Copy link
Contributor Author

Dandandan commented Mar 17, 2026

@adriangb perhaps wanna review? :)

adriangb
adriangb approved these changes Mar 17, 2026
View reviewed changes
Copy link
Contributor

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@adriangb
Copy link
Contributor

adriangb commented Mar 17, 2026

I'm not a committer :(

@alamb alamb merged commit 68b6076 into apache:main Mar 17, 2026
16 checks passed
@alamb
Copy link
Contributor

alamb commented Mar 17, 2026

🚀

Back on this repo now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

+1 more reviewer

@adriangb adriangb adriangb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

parquet Changes to the parquet crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dandandan @adriangbot @adriangb @alamb