DeltaBitPackEncoderConversion: Fix panic message on invalid type#9552
Merged
alamb merged 7 commits intoapache:mainfrom Mar 17, 2026
Merged
DeltaBitPackEncoderConversion: Fix panic message on invalid type#9552alamb merged 7 commits intoapache:mainfrom
alamb merged 7 commits intoapache:mainfrom
Conversation
progval
force-pushed
the
DeltaBitPackEncoderConversion-error-msg
branch
from
30a208a to
b2765c3
Compare
progval
force-pushed
the
DeltaBitPackEncoderConversion-error-msg
branch
from
b2765c3 to
6d517de
Compare
Contributor
|
@progval Can you add a test for this? |
alamb
reviewed
Mar 17, 2026
alamb
approved these changes
Mar 17, 2026
| @@ -0,0 +1,50 @@ | |||
| // Licensed to the Apache Software Foundation (ASF) under one | |||
Contributor
There was a problem hiding this comment.
While it is strange to have a new integration test just for this error message, I agree starting to have an arrow_writer suite is a good step forward
…hub.com/progval/arrow-rs into DeltaBitPackEncoderConversion-error-msg
…nversion-error-msg
Contributor
|
Thanks again @progval |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
DeltaBitPackDecoder supports Int32Type, UInt32Type, Int64Type, and UInt64Type; but the error message claimed it supported only Int32Type and Int64Type
What changes are included in this PR?
ensure_phys_ty!()to allow anythingpanic!()doesAre these changes tested?
no
Are there any user-facing changes?
only the panic message