-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(arrow-avro): HeaderInfo to expose OCF header
#9548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alamb
merged 5 commits into
apache:main
from
mzabaluev:avro-reader-builder-with-header-info
Mar 18, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0b7032a
feat(arrow-avro): HeaderInfo to expose OCF header
mzabaluev 57ee444
test: build_with_header for AsyncAvroFileReader
mzabaluev 7124ca5
test: check properties of HeaderInfo
mzabaluev a53e752
docs: review suggestions on HeaderInfo and adjacent
mzabaluev 4e57460
refactor: reuse HeaderInfo in async avro reader
mzabaluev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -500,7 +500,9 @@ mod record; | |
| mod vlq; | ||
|
|
||
| #[cfg(feature = "async")] | ||
| mod async_reader; | ||
| pub mod async_reader; | ||
|
|
||
| pub use header::{HeaderInfo, read_header_info}; | ||
|
|
||
| #[cfg(feature = "object_store")] | ||
| pub use async_reader::AvroObjectReader; | ||
|
|
@@ -1273,7 +1275,7 @@ impl ReaderBuilder { | |
| /// the discovered writer (and optional reader) schema, and prepares to iterate blocks, | ||
| /// decompressing if necessary. | ||
| pub fn build<R: BufRead>(self, mut reader: R) -> Result<Reader<R>, ArrowError> { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do think there's value in adding the |
||
| let header = read_header(&mut reader)?; | ||
| let (header, _) = read_header(&mut reader)?; | ||
| let decoder = self.make_decoder(Some(&header), self.reader_schema.as_ref())?; | ||
| Ok(Reader { | ||
| reader, | ||
|
|
@@ -1632,7 +1634,7 @@ mod test { | |
|
|
||
| fn load_writer_schema_json(path: &str) -> Value { | ||
| let file = File::open(path).unwrap(); | ||
| let header = super::read_header(BufReader::new(file)).unwrap(); | ||
| let (header, _) = super::read_header(BufReader::new(file)).unwrap(); | ||
| let schema = header.schema().unwrap().unwrap(); | ||
| serde_json::to_value(&schema).unwrap() | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.