Skip to content

perf: improve GenericByteBuilder::append_array to use SIMD for extending the offsets #8388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Sep 22, 2025
Merged

perf: improve GenericByteBuilder::append_array to use SIMD for extending the offsets #8388

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ee80db
perf: improve GenericByteBuilder::append_array to use SIMD for extend…
rluvaton Sep 18, 2025
fd5a012
change to iterator that will also use SIMD without intermediate buffer
rluvaton Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions arrow-array/src/builder/generic_bytes_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,15 @@ impl<T: ByteArrayType> GenericByteBuilder<T> {
// Shifting all the offsets
let shift: T::Offset = self.next_offset() - offsets[0];

// Creating intermediate offsets instead of pushing each offset is faster
// (even if we make MutableBuffer to avoid updating length on each push
// and reserve the necessary capacity, it's still slower)
let mut intermediate = Vec::with_capacity(offsets.len() - 1);
use num::Zero;

for &offset in &offsets[1..] {
intermediate.push(offset + shift)
// Creating intermediate offsets instead of pushing each offsets is faster.
//
// Not using Vec::with_capacity and push as it will not use SIMD for some reason.
let mut intermediate = vec![T::Offset::zero(); offsets.len() - 1];

for (index, &offset) in offsets[1..].iter().enumerate() {
intermediate[index] = offset + shift;
}

self.offsets_builder.extend_from_slice(&intermediate);
Expand Down
Loading