Skip to content

feat(go/adbc/driver/flightsql): handle is_update in prepared stmts #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ennuite wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat(go/adbc/driver/flightsql): handle is_update in prepared stmts #4161

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37dce6e
Add new network route via cursor.execute()
ennuite Mar 24, 2026
9b1aaef
Expose new option to read the value of the field is_update in ActionC…
ennuite Mar 31, 2026
0a921bb
Revert changes on Python drivers
ennuite Apr 2, 2026
0ab4e00
Add new network flow to ADBC Go Statement.ExecuteQuery() for prepared…
ennuite Apr 3, 2026
6d5a113
Add tests
ennuite Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions go/adbc/driver/flightsql/flightsql_statement.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,14 @@ func (s *statement) ExecuteQuery(ctx context.Context) (rdr array.RecordReader, n
var header, trailer metadata.MD
opts := append([]grpc.CallOption{}, grpc.Header(&header), grpc.Trailer(&trailer), s.timeouts)
if s.prepared != nil {
if isUpdate := s.prepared.IsUpdate(); isUpdate != nil && *isUpdate {
nrec, err = s.prepared.ExecuteUpdate(ctx, opts...)
if err != nil {
return nil, -1, adbcFromFlightStatusWithDetails(err, header, trailer, "ExecuteUpdate")
}
rdr, err = array.NewRecordReader(arrow.NewSchema(nil, nil), nil)
return
}
info, err = s.prepared.Execute(ctx, opts...)
} else {
info, err = s.query.execute(ctx, s.cnxn, opts...)
Expand Down