Enforce provider-only JMSX properties under strictCompliance#1853
Open
pradeep85841 wants to merge 2 commits intoapache:mainfrom
Open
Enforce provider-only JMSX properties under strictCompliance#1853pradeep85841 wants to merge 2 commits intoapache:mainfrom
pradeep85841 wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
pradeep85841
commented
Mar 28, 2026
pradeep85841
commented
- Throws a MessageNotWriteableException if a client attempts to set JMSXDeliveryCount, JMSXRcvTimestamp, JMSXState, JMSXProducerTXID, or JMSXConsumerTXID.
- Client-set properties (like JMSXGroupID and JMSXGroupSeq) are completely bypassed and function normally.
- Added StrictComplianceProviderJMSXPropertyTest using an embedded BrokerService to explicitly verify both strict and legacy behaviors.
jbonofre
requested changes
Mar 29, 2026
| Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE)) { | ||
|
|
||
| connection.start(); | ||
| Message message = (Message) session.createMessage(); |
Member
There was a problem hiding this comment.
I don't see Message in the import, I think it won't compile 😄
| "JMSXState".equals(name) || | ||
| "JMSXProducerTXID".equals(name) || | ||
| "JMSXConsumerTXID".equals(name)) { | ||
| throw new MessageNotWriteableException("Provider-set JMSX property '" + name + "' cannot be set by a client under strict compliance."); |
Member
There was a problem hiding this comment.
I'm not sure we should use MessageNotWriteableException here.
MessageNotWriiteableException is specified in JMS for when a message is in read-only mode (received). For a provider-only property that clients should never set, I think a JMSException with a clear message might be more semantically accurate.
The distinction matters because a client catching MessageNotWriteableException might assume calling clearProperties() would fix it, but it won't (since this is a permanent restriction, not a state-based one).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.