Skip to content

fix: dependency_on_unit_never_type_fallback#2551

Merged
yihau merged 1 commit intoanza-xyz:masterfrom
yihau:fix-unit-never-type-fall
Aug 12, 2024
Merged

fix: dependency_on_unit_never_type_fallback#2551
yihau merged 1 commit intoanza-xyz:masterfrom
yihau:fix-unit-never-type-fall

Conversation

@yihau
Copy link
Copy Markdown
Member

@yihau yihau commented Aug 12, 2024

(part of #2487)

Problem

Screenshot 2024-08-11 at 19 13 28

Summary of Changes

use a more specific type for the collect function

@yihau yihau marked this pull request as ready for review August 12, 2024 13:41
@yihau yihau requested review from joncinque and steviez August 12, 2024 13:41
Copy link
Copy Markdown

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@yihau yihau merged commit 8223dfc into anza-xyz:master Aug 12, 2024
@yihau yihau deleted the fix-unit-never-type-fall branch August 12, 2024 14:17
ray-kast pushed a commit to abklabs/agave that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants