Skip to content

Fix: valu and debug engine literal missing#34

Open
zhangddjs wants to merge 1 commit intoanthropics:mainfrom
zhangddjs:fix/engine_literal
Open

Fix: valu and debug engine literal missing#34
zhangddjs wants to merge 1 commit intoanthropics:mainfrom
zhangddjs:fix/engine_literal

Conversation

@zhangddjs
Copy link
Copy Markdown

@zhangddjs zhangddjs commented Feb 11, 2026

as original defined engine only has ["alu", "load", "store", "flow"]

Engine = Literal["alu", "load", "store", "flow"]

Which should be conflict against given example and ENGINE_FNS:

"""
Here's an example of what an instruction might look like:

{"valu": [("*", 4, 0, 0), ("+", 8, 4, 0)], "load": [("load", 16, 17)]}
"""

ENGINE_FNS = {
    "alu": self.alu,
    "valu": self.valu,    # <-- here valu engine missing
    "load": self.load,
    "store": self.store,
    "flow": self.flow,
}

So I decided to add the missing "valu" and "debug" engine

-- Engine = Literal["alu", "load", "store", "flow"]
++ Engine = Literal["alu", "valu", "load", "store", "flow", "debug"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant