Fix for Issue #18: Chunk streaming issues for traces with some browsers#19
Open
Sneakercopter wants to merge 1 commit intoanthropics:mainfrom
Open
Fix for Issue #18: Chunk streaming issues for traces with some browsers#19Sneakercopter wants to merge 1 commit intoanthropics:mainfrom
Sneakercopter wants to merge 1 commit intoanthropics:mainfrom
Conversation
… in some browsers when fetching large traces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies the fix proposed in issue #18 where it was identified that hot reloading was not working on some browsers for bigger traces due to an issue with how Javascript was handling the chunked stream.
The fix applied introduces a new async function
getBlobFromTracewhich explicitly reads all chunks with a ReadableStream and then when complete creates and returns a blob of the results. This method is now called from bothfetchAndOpenandrepollso that the both initial opening of a stream and repolling on file changes works correctly.