Draft
Conversation
Member
|
Can we colorize each type, and also provide a hover dialog for each item? It's a bit tricky to understand how it represents right now. The latest commit should contains floating vue and some color utilities |
added 2 commits
September 18, 2024 15:13
refactor: waterfall via echarts
src/client/pages/index/waterfall.vue
Outdated
| yAxis: { | ||
| data: categories.value, | ||
| } satisfies SingleAxisComponentOption, | ||
| series: [ |
There was a problem hiding this comment.
group by id or plugin name ?
|
maybe should add the following period segmentation, otherwise its need to zoom to the millisecond level to see the ‘<1ms’ block |
Author
|
It seems that we should render the first load and each HMR separately. Otherwise, the time span is too long, which makes everything hard to see. |
indeed, and maybe should added more filters |
split hmr time range
…in-inspect into feat/waterfall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Waterfall/timeline view. Feedback welcome.
Currently I am not having the time to work on this 🥹