fix(sender): avoid submit after composition end in safari by IsDyh01 · Pull Request #1732 · ant-design/x

IsDyh01 · 2026-02-05T12:55:39Z

🤔 This is a ...

🔗 Related Issues

Describe the source of related requirements, such as links to relevant issue discussions.

For example: close #xxxx, fix #xxxx

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://x.ant.design/changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

Summary by CodeRabbit

错误修复
- 优化文本输入区域中 Enter 键的处理：在输入法（如中文、日文）组合结束后的短时间内（约100毫秒）按 Enter 不再误触提交，避免在组合刚结束时意外发送消息。

github-actions · 2026-02-05T12:55:50Z

gemini-code-assist · 2026-02-05T12:55:53Z

Summary of Changes

Hello @IsDyh01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug where pressing Enter immediately after an IME composition finishes could lead to an unintended form submission, particularly in Safari. The fix introduces a short delay after composition ends to differentiate between a composition completion and an intentional Enter key press for submission, thereby improving the reliability of text input in the TextArea component.

Highlights

Safari Composition Bug Fix: Implemented a mechanism to prevent accidental form submission immediately after an input method editor (IME) composition ends, specifically addressing an issue observed in Safari browsers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

packages/x/components/sender/components/TextArea.tsx
- Introduced a lastCompositionEndTick ref to record the timestamp when an input method editor (IME) composition ends.
- Modified the onInternalCompositionEnd handler to update the lastCompositionEndTick with the current time.
- Updated the onInternalKeyDown handler to include a new condition that prevents form submission if an Enter key press occurs within 100 milliseconds of an IME composition ending, mitigating a specific bug in Safari.

Activity

No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

coderabbitai · 2026-02-05T12:56:02Z

📝 Walkthrough

Walkthrough

在 TextArea 中添加了对输入法组合（composition）结束后的短暂冷却：记录最近一次 compositionend 的时间戳，并在 Enter 键处理时若在 100ms 内刚结束组合则阻止提交。新增单元测试覆盖该场景。

Changes

Cohort / File(s)	Summary
组合事件冷却机制 `packages/x/components/sender/components/TextArea.tsx`	新增内部 ref `lastCompositionEndTick`，在 compositionend 更新时间戳；在 Enter 键处理逻辑中加入 100ms 冷却校验以避免组合刚结束时触发提交。
测试覆盖 `packages/x/components/sender/__tests__/index.test.tsx`	新增测试：在 compositionStart → compositionEnd 后 100ms 内按 Enter（无 Shift）不应触发 onSubmit。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 分钟

诗歌

🐰 小小时间戳，静守片刻宁静

组合落笔处，Enter 暂缓轻声应
百毫秒的温柔，避免误触惊醒
兔兔在角落，悄悄修好每一行 ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	标题清晰准确地总结了主要变更：修复在Safari中composition事件后避免提交的问题，与代码变更内容完全相关。
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request introduces a fix to prevent unintended form submission after an IME composition ends, a known issue in Safari. The approach of using a timestamp to create a small debounce period after compositionend is a sound solution. My feedback focuses on improving code maintainability by replacing a magic number with a named constant, which will make the code clearer and easier to manage.

packages/x/components/sender/components/TextArea.tsx

codecov · 2026-02-05T12:58:56Z

Bundle Report

Changes will increase total bundle size by 68 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antdx-array-push	1.91MB	68 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: antdx-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antdx.min.js`	68 bytes	1.91MB	0.0%

codecov · 2026-02-05T13:04:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (e77f65a) to head (3e24d03).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1732      +/-   ##
==========================================
+ Coverage   97.34%   97.41%   +0.06%     
==========================================
  Files         144      144              
  Lines        4598     4606       +8     
  Branches     1295     1307      +12     
==========================================
+ Hits         4476     4487      +11     
+ Misses        120      117       -3     
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kimteayon · 2026-02-06T08:31:40Z

我研究下应该有特性判断

IsDyh01 · 2026-02-06T09:52:37Z

我研究下应该有特性判断

是不是可以通过keyocde=229来判断，不管是safari还是google那些浏览器，只要是组合状态下keycode都为229

fix(sender): avoid submit after composition end

9901c53

dosubot bot added the bug Something isn't working label Feb 5, 2026

gemini-code-assist bot reviewed Feb 5, 2026

View reviewed changes

packages/x/components/sender/components/TextArea.tsx Outdated Show resolved Hide resolved

IsDyh01 and others added 2 commits February 5, 2026 21:12

test(sender): cover composition debounce

a41837d

Merge branch 'main' into fix/sender-combined-submit-error

3e24d03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(sender): avoid submit after composition end in safari#1732

fix(sender): avoid submit after composition end in safari#1732
IsDyh01 wants to merge 3 commits intoant-design:mainfrom
IsDyh01:fix/sender-combined-submit-error

IsDyh01 commented Feb 5, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

github-actions bot commented Feb 5, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 5, 2026

Uh oh!

coderabbitai bot commented Feb 5, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

诗歌

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

codecov bot commented Feb 5, 2026 •

edited

Loading

Assets Changed:

Uh oh!

codecov bot commented Feb 5, 2026 •

edited

Loading

Uh oh!

kimteayon commented Feb 6, 2026

Uh oh!

IsDyh01 commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

IsDyh01 commented Feb 5, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Summary by CodeRabbit

Uh oh!

github-actions bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 5, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

coderabbitai bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

诗歌

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

codecov bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

codecov bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kimteayon commented Feb 6, 2026

Uh oh!

IsDyh01 commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

IsDyh01 commented Feb 5, 2026 •

edited by coderabbitai bot

Loading

github-actions bot commented Feb 5, 2026 •

edited

Loading

coderabbitai bot commented Feb 5, 2026 •

edited

Loading

codecov bot commented Feb 5, 2026 •

edited

Loading

codecov bot commented Feb 5, 2026 •

edited

Loading