Skip to content

fix: disable mouse tracking before restoring cooked mode in finalizeDestroy #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adyavanapalli wants to merge 1 commit into from
Closed

fix: disable mouse tracking before restoring cooked mode in finalizeDestroy #802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/core/src/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1930,7 +1930,14 @@ export class CliRenderer extends EventEmitter implements RenderContext {
console.error("Error destroying root renderable:", e instanceof Error ? e.stack : String(e))
}

// Remove listener before destroying parser
// Disable mouse tracking while still in raw mode so the terminal stops
// generating SGR mouse events before we restore cooked mode. Without this,
// any mouse movement between setRawMode(false) and destroyRenderer() leaks
// partial escape sequences (e.g. "35;80;40M") onto the user's shell prompt.
if (this._useMouse) {
this.disableMouse()
}

this.stdin.removeListener("data", this.stdinListener)
if (this.stdin.setRawMode) {
this.stdin.setRawMode(false)
Expand Down
Loading