Open
Conversation
|
saya 🫡 buatin untuk yang agama lain juga bang biar adil |
Author
|
Boleh bro, asal ada API nya, tapi mending di widget berbeda biar lebih rapih. khusus untuk widget ini ya islamic prayer times aja. |
|
for non indonesians: me: miraquel: |
Owner
|
@miraquel thanks for the PR, can you please clean up the commit history? All this can be one commit. |
94fe0cc to
ad55402
Compare
Author
|
@amnweb Done. Thank you for the feedback |
Owner
|
@miraquel is this written by AI? |
Author
|
@amnweb Yes, it is. I'm using it right now and testing it extensively. |
Owner
|
Yeah, I see mixed English and Chinese/Japanese characters in the logs, that's why i ask. |
- Implement Prayer Times widget with Aladhan API integration - Support configurable city, country, calculation method, and school - Display current and next prayer times with countdown timer - Add flash animation for prayer time notifications with grace period - Add retry mechanism for network failures - Support tooltip with full daily prayer schedule - Add popup menu with all prayer times for the day - Add callback actions and menu configuration options - Support debug option for flash configuration - Include icon mapping for each prayer time
ad55402 to
564ad0e
Compare
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pull request introduces a new API data fetcher for Islamic prayer times and adds a comprehensive configuration model for the prayer times widget. The main changes are the addition of a robust Qt-based fetcher class to handle API requests and retries, and a detailed Pydantic-based configuration schema to customize widget behavior, appearance, and interactions.
API integration:
Added the PrayerTimesDataFetcher class in api.py to handle periodic fetching of prayer times from the Aladhan API, including error handling, retry logic, and signal emission for downstream processing.
Widget configuration:
Introduced PrayerTimesConfig and related Pydantic models in prayer_times.py to define widget settings such as location, calculation method, display format, icons, menu appearance, flash behavior, and callbacks, enabling extensive customization and validation.
Defined specialized configs for icons (PrayerTimesIconsConfig), menu (PrayerTimesMenuConfig), flash alerts (PrayerTimesFlashConfig), and callbacks (PrayerTimesCallbacksConfig), allowing granular control over each widget aspect.
These changes lay the groundwork for a reliable, highly configurable prayer times widget that supports robust data fetching and flexible user interface options.