feat(update check): Adds optional Windows Update popup menu#763
feat(update check): Adds optional Windows Update popup menu#763CodeRedPaul wants to merge 1 commit intoamnweb:mainfrom
Conversation
Introduces `show_popup_menu` and `popup_menu_padding` configuration options for the Windows Update source. This allows users to enable a popup menu on left-click instead of directly opening Windows Update settings. The popup menu offers two choices: - Open Windows Update in Settings. - Directly update Windows Defender virus security intelligence, which prompts for UAC elevation. Includes dedicated styling for the new popup menu and its items.
|
To be honest, this is not needed. I mean, if we cannot have a consistent UI for all of this where we have Scoop, Winget and Windows Update, I'm not thinking about merging this. You can simply ignore these updates by adding |
That's totally fine and I respect your decision. As I said, I mainly did to prove that I could. Also TBH, the exclusion option was documented but the way it was worded made me think it needed an exact match. Peace. ✌️ |
Summary
Introduces
show_popup_menuandpopup_menu_paddingconfiguration options for the Update Check - Windows Update source. This allows users to enable a popup menu on left-click instead of directly opening Windows Update settings.The popup menu offers two choices:
Includes dedicated styling for the new popup menu and its items.
Features Implemented
WindowsUpdateConfigfor the Update Check widget.config.yamlconfig.yamlChanges
styles.cssUsage Example
In Action
Showing more details on the UAC prompt will indicate what the command will run:

Related Issues
Only indirectly related, but I note that this feature will need some minor amendments should PR #744 be approved as it consumes the Popup widget and will need to meet the new standard.
Rationale
I got very confused with this widget when I first started to use YASB. The left-click opens Windows Update but I could get 4 or 5 notifications throughout the day indicating my virus definitions needed updating. Looking at Windows Update it reported no updates available.
Originally I was left scratching my head trying to work out how to remove these 'rogue' notifications that wouldn't go away unless I clicked through multiple items to manually update Windows Defender's security intelligence. I even created a shortcut I could run from my desktop to alleviate the burden, and then I decided to try incorporating it into the widget itself.
I now know what happens under the covers. I'd already started this contribution before I fully realized the relationship between Windows Defender and Windows Update, but I figured I would continue for 2 main reasons:
Acknowledgements and Thanks
I would like to acknowledge the vast amount that I leant on the work of SavedByGrace251 in his PR #521. I reused a lot of his work and would not have been able to produce this contribution without retrofitting his hard work into this widget. Thank you.
Caveats and Feedback
This is my first time working on YASB, my first time working with Python and my first time contributing to an open source project. Any mistakes or omissions are of course entirely my own.
Please do provide feedback and constructive criticism where due. I can't do it right in the future if I don't know what I'm doing wrong now. That includes the whole idea of this feature. I won't mind at all should this not be accepted. I really just did it to prove that I could but I hope others might see and extract some value from it.