Fixed memory leak in LocationMap::remove#251
Open
ImmemorConsultrixContrarie wants to merge 1 commit into
Open
Conversation
World::removeLocationMap::remove
6 tasks
Collaborator
|
If we keep a count next to each array, we could maintain that and remove the entry when the count becomes 0, rather than have to scan through the array to check for all nones on every remove. |
Contributor
Author
That's true and I had a thought about it, but that required too much code to write at the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245.
The initial solution has obvious worst case: inserting a single entity and then removing it, which would allocate the block in the heap and then deallocate the same block.
What could be done about it:
[T; N]instead ofBox<[T; N]>. This would make hashmap storage slower to reallocate, but totally avoids single entity allocation problem and lessens indirection.