Open
Conversation
added 2 commits
January 9, 2024 18:50
instead of server_name. this is now used on all hosted envs to work out cookie details - see alphagov/document-download-frontend#205 for details. note: you will need to update your private doc dl frontend file to reflect the change in var name diff --git a/document-download-frontend.env.tmpl b/document-download-frontend.env.tmpl index b6f4412..a959450 100644 --- a/document-download-frontend.env.tmpl +++ b/document-download-frontend.env.tmpl @@ -4,7 +4,7 @@ FLASK_DEBUG=1 WERKZEUG_DEBUG_PIN=off NOTIFY_ENVIRONMENT=development -SERVER_NAME=frontend.document-download.localhost:7001 +DOCUMENT_DOWNLOAD_FRONTEND_HOST_NAME=frontend.document-download.localhost:7001 API_HOST_NAME=http://notify-api.localhost:6011 DOCUMENT_DOWNLOAD_API_HOST_NAME=http://api.document-download.localhost:7000
leohemsted
force-pushed
the
local-dev-updates
branch
from
19c7836 to
f6939ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these are needed for doc dl development.
You'll want to edit your
private/document-download-frontend.envfile to rename server_name to document_download_frontend_hostnameProbs best to be merged shortly after