chore(gitignore): post-merge-feedback pending file を除外 (ADR-029)#74
Merged
chore(gitignore): post-merge-feedback pending file を除外 (ADR-029)#74
Conversation
cli-merge-pipeline が生成する `.claude/post-merge-feedback-pending.json` は hooks-stop-feedback-dispatch / post-merge-feedback skill が consume する一時 artifact で、コミットに含めるべきではない。ADR-029 の task 1-B/1-C 実装時に .gitignore 登録が漏れていたため補完する。 skill crash 時などに short window で残存するが、次回の Phase 0 で consumed/stale 分岐により自動回収される設計。
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
4 tasks
aloekun
added a commit
that referenced
this pull request
Apr 25, 2026
PR #75 の post-merge-feedback で得られた Tier 1 提案を実装。 custom-lint-rules.toml に新規 rule を追加: - pattern: 'C:\Users\[A-Za-z][A-Za-z0-9_-]+\|/home/[a-z][a-z0-9_-]+/' - extensions: md / txt - severity: error - placeholder (<USER_NAME>, %USERPROFILE%, ~/, $HOME) は character class ([A-Za-z] / [a-z]) で開始位置を縛り自動除外 由来: PR #75 で同種 PII 指摘が 3 箇所同時発生 (ADR-030 line 143、 todo.md line 35/48)。PR #74 でも前例あり、CodeRabbit Major 指摘の 頻出パターンとして Plankton Tier 1 (決定論的防止) で固定化する。 カスタムリンタは std::fs::read_to_string で runtime ロードのため exe rebuild 不要。既存 45 件のリンターテスト全 PASS で regex 妥当性確認済。
4 tasks
aloekun
added a commit
that referenced
this pull request
Apr 25, 2026
PR #75 の post-merge-feedback で得られた Tier 1 提案を実装。 custom-lint-rules.toml に新規 rule を追加: - pattern: 'C:\Users\[A-Za-z][A-Za-z0-9_-]+\|/home/[a-z][a-z0-9_-]+/' - extensions: md / txt - severity: error - placeholder (<USER_NAME>, %USERPROFILE%, ~/, $HOME) は character class ([A-Za-z] / [a-z]) で開始位置を縛り自動除外 由来: PR #75 で同種 PII 指摘が 3 箇所同時発生 (ADR-030 line 143、 todo.md line 35/48)。PR #74 でも前例あり、CodeRabbit Major 指摘の 頻出パターンとして Plankton Tier 1 (決定論的防止) で固定化する。 カスタムリンタは std::fs::read_to_string で runtime ロードのため exe rebuild 不要。既存 45 件のリンターテスト全 PASS で regex 妥当性確認済。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/post-merge-feedback-pending.jsonを.gitignoreに追加Context
PR #73 merge 後の dogfood で
.claude/post-merge-feedback-pending.jsonが working copy にA(Added) として現れることが判明。ADR-029 の pending file は cli-merge-pipeline / hooks-stop-feedback-dispatch / post-merge-feedback skill が生成・consume する runtime artifact で、.gitignore登録が必要だが、task 1-B (PR #70) / 1-C (PR #71) 実装時に見落とされていた。既存
.claude/pr-monitor-state.json等の runtime state 系パターンと同じ位置 (Runtime generated files セクション) に追加することで、.gitignoreの論理構造を保つ。skill crash 時などに pending file が短時間残存するケースもあるが、次回の Phase 0 でconsumed/stale/corrupt分岐により自動回収される設計なので、.gitignoreの適用範囲は「誤コミット防止」のみで十分。Validation
pnpm pushpre-push-review:verdict=APPROVE(最終 1 iteration 1m 32s, simplicity/security 両方 approved)jj diff --stat:.gitignore | 2 ++— コメント 1 行 + ignore pattern 1 行のみ、他ファイル unchanged.session-id,pr-monitor-state*.json,scheduled_tasks.lock) と同じブロック内で追加、論理構造保持References
Summary by CodeRabbit
リリースノート
.gitignoreを更新しました。