Reset full to false when pop from bytes queue#223
Merged
siennathesane merged 1 commit intoallegro:masterfrom May 29, 2020
Merged
Reset full to false when pop from bytes queue#223siennathesane merged 1 commit intoallegro:masterfrom
siennathesane merged 1 commit intoallegro:masterfrom
Conversation
Related to issue allegro#214
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 90.61% 89.09% -1.53%
==========================================
Files 15 15
Lines 714 715 +1
==========================================
- Hits 647 637 -10
- Misses 58 66 +8
- Partials 9 12 +3
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
siennathesane
approved these changes
May 29, 2020
Collaborator
siennathesane
left a comment
siennathesane
left a comment
There was a problem hiding this comment.
lgtm, thanks for bug hunting!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When byte queue is full, it will set
queue.full=truebut when evict and pop entry from queue, it does not set to false again. It causes bigcache cannot insert new entries once the queue is full.This commit set
queue.full=falsewhen pop entry from queue, and add a test case which failed in current master ccdbc60 and passed in this commit.Related to issue #214
And it seems the same problem in Pull Request #218