Resolving some importing issues with omwp044_vinfinity_matching and a…#54
Open
pjconradie wants to merge 2 commits intoalfonsogonzalez:mainfrom
Open
Conversation
… plotting error Hey Alfonso, this is an example of some of the issues I ran into. These where simple to fix however (assuming that everything is working as it should be). 1. AWP_path is set through environment variables to the git root: "*/AWS" 2. The kernels from SPICE are all now in the "AWP/data/spice/*" directory - I moved 'voyager2_jupiter_flyby.bsp' into "AWP/data/spice/spk" 3. When mounting the SPICE kernels the python scripts use the "AWS" git rot and joins it with the specific data path to the SPICE kernel I also had to modify the "plotting_tool.py" changing w_xaxis, w_yaxis and w_zaxis to xaxis, yaxis and zaxis There are similar bugs that in the omwp043_patched_conics example that I mentioned by email. Let me know if I am missing something, otherwise Ill see what I can modify moving forward and submit the pull requests.
Author
|
Hey Alfonso, thanks for sharing the repo. Excellent piece of work. Just ran into some issues. Let me know of this is not correct or if I missunderstood somethings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… plotting error
Hey Alfonso, this is an example of some of the issues I ran into. These where simple to fix however (assuming that everything is working as it should be).
I also had to modify the "plotting_tool.py" changing w_xaxis, w_yaxis and w_zaxis to xaxis, yaxis and zaxis
There are similar bugs that in the omwp043_patched_conics example that I mentioned by email.
Let me know if I am missing something, otherwise Ill see what I can modify moving forward and submit the pull requests.