Draft
Conversation
Contributor
Author
|
ready for review, draft because it must wait for the runtime |
pvlugter
approved these changes
Mar 31, 2026
| include::example$key-value-shopping-cart/src/main/java/com/example/application/ShoppingCartMetrics.java[tag=metrics] | ||
| ---- | ||
| <1> Injects the OpenTelemetry `Meter` provided by the Akka runtime. | ||
| <2> Creates a custom counter metric. Please follow Open Telemetry |
Member
There was a problem hiding this comment.
should be "Please follow Open Telemetry semantic conventions"?
Suggested change
| <2> Creates a custom counter metric. Please follow Open Telemetry | |
| <2> Creates a custom counter metric. Please follow Open Telemetry semantic conventions. |
| | `akka.javasdk.Sanitizer` | ||
| | Allows for applying sanitization, see xref:sdk:sanitization.adoc[] | ||
| | `io.opentelemetry.api.metrics.Meter` | ||
| | Allows to create custom Open Telemetry metrics, see xref:sdk:metric.adoc[] |
Member
There was a problem hiding this comment.
Suggested change
| | Allows to create custom Open Telemetry metrics, see xref:sdk:metric.adoc[] | |
| | Allows creating custom Open Telemetry metrics, see xref:sdk:metric.adoc[] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: https://github.com/lightbend/akka-runtime/pull/4973