Provide jump commands completion for nushell#1072
Open
alecandido wants to merge 1 commit intoajeetdsouza:mainfrom
Open
Provide jump commands completion for nushell#1072alecandido wants to merge 1 commit intoajeetdsouza:mainfrom
alecandido wants to merge 1 commit intoajeetdsouza:mainfrom
Conversation
Create completing function, wrapping zoxide query, and attach to jumping commands arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For custom commands (defined in Nushell itself), completion has to be directly attached to the command definition
https://www.nushell.sh/book/custom_completions.html#custom-completions
So, better to provide completion in the template itself :)
Notice that there is an entire section in the official docs of Nushell discussing zoxide completion
https://www.nushell.sh/cookbook/external_completers.html#zoxide-completer
However,
i.e., it always assumes that zoxide commands are provided as external ones. While the Nushell template is defining
__zoxide_zand__zoxide_zias custom commands (internal ones).